threads / patch / 17552

patchurls.txt: document optional port specification in git URLS

Subject: [PATCH] urls.txt: document optional port specification in git URLS

## tl;dr

9 messages between Feb 4, 2009 and Feb 5, 2009. Diffs are folded; open one to read it.

replies: 8people: 5as markdown or json

Stefan Naewe· Feb 4, 2009, 11:51 UTC · lore

Signed-off-by: Stefan Naewe <stefan.naewe@atlas-elektronik.com>
---
 Documentation/urls.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to Documentation/urls.txt +2 −2

diff --git a/Documentation/urls.txt b/Documentation/urls.txt
index fa34c67..c74f00b 100644
--- a/Documentation/urls.txt
+++ b/Documentation/urls.txt
@@ -8,8 +8,8 @@ to name the remote repository:
 - rsync://host.xz/path/to/repo.git/
 - http://host.xz/path/to/repo.git/
 - https://host.xz/path/to/repo.git/
-- git://host.xz/path/to/repo.git/
-- git://host.xz/~user/path/to/repo.git/
+- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
+- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
 - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
 - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
 - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/

-- 
1.6.1.2

Junio C Hamano· Feb 4, 2009, 18:09 UTC · re: Stefan Naewe · lore

Re: [PATCH] urls.txt: document optional port specification in git URLS

Stefan Naewe <stefan.naewe@atlas-elektronik.com> writes:

Show 20 quoted lines

> Signed-off-by: Stefan Naewe <stefan.naewe@atlas-elektronik.com>
> ---
>  Documentation/urls.txt |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/urls.txt b/Documentation/urls.txt
> index fa34c67..c74f00b 100644
> --- a/Documentation/urls.txt
> +++ b/Documentation/urls.txt
> @@ -8,8 +8,8 @@ to name the remote repository:
>  - rsync://host.xz/path/to/repo.git/
>  - http://host.xz/path/to/repo.git/
>  - https://host.xz/path/to/repo.git/
> -- git://host.xz/path/to/repo.git/
> -- git://host.xz/~user/path/to/repo.git/
> +- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
> +- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/

Hmph, I wonder if we want that for http:// and https://, too.

Stefan Naewe· Feb 4, 2009, 20:49 UTC · re: Junio C Hamano · lore

[PATCH v2] urls.txt: document optional port specification in git URLS

Signed-off-by: Stefan Naewe <stefan.naewe+git@gmail.com>
---
 Documentation/urls.txt |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Show changes to Documentation/urls.txt +4 −4

diff --git a/Documentation/urls.txt b/Documentation/urls.txt
index fa34c67..5355ebc 100644
--- a/Documentation/urls.txt
+++ b/Documentation/urls.txt
@@ -6,10 +6,10 @@ to name the remote repository:
 
 ===============================================================
 - rsync://host.xz/path/to/repo.git/
-- http://host.xz/path/to/repo.git/
-- https://host.xz/path/to/repo.git/
-- git://host.xz/path/to/repo.git/
-- git://host.xz/~user/path/to/repo.git/
+- http://host.xz{startsb}:port{endsb}/path/to/repo.git/
+- https://host.xz{startsb}:port{endsb}/path/to/repo.git/
+- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
+- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
 - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
 - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
 - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/

-- 
1.6.1.2

Junio C Hamano· Feb 4, 2009, 20:53 UTC · re: Stefan Naewe · lore

Re: [PATCH v2] urls.txt: document optional port specification in git URLS

Stefan Naewe <stefan.naewe@googlemail.com> writes:

Show 24 quoted lines

> Signed-off-by: Stefan Naewe <stefan.naewe+git@gmail.com>
> ---
>  Documentation/urls.txt |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/urls.txt b/Documentation/urls.txt
> index fa34c67..5355ebc 100644
> --- a/Documentation/urls.txt
> +++ b/Documentation/urls.txt
> @@ -6,10 +6,10 @@ to name the remote repository:
>  
>  ===============================================================
>  - rsync://host.xz/path/to/repo.git/
> -- http://host.xz/path/to/repo.git/
> -- https://host.xz/path/to/repo.git/
> -- git://host.xz/path/to/repo.git/
> -- git://host.xz/~user/path/to/repo.git/
> +- http://host.xz{startsb}:port{endsb}/path/to/repo.git/
> +- https://host.xz{startsb}:port{endsb}/path/to/repo.git/
> +- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
> +- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/

Do you know if these port specifications do actually work? Just double checking.

Stefan Näwe· Feb 4, 2009, 21:02 UTC · re: Junio C Hamano · lore

Re: [PATCH v2] urls.txt: document optional port specification in git URLS

Junio C Hamano <gitster <at> pobox.com> writes:

Show 20 quoted lines

> 
> Stefan Naewe <stefan.naewe <at> googlemail.com> writes:
> 
> >  ===============================================================
> >  - rsync://host.xz/path/to/repo.git/
> > -- http://host.xz/path/to/repo.git/
> > -- https://host.xz/path/to/repo.git/
> > -- git://host.xz/path/to/repo.git/
> > -- git://host.xz/~user/path/to/repo.git/
> > +- http://host.xz{startsb}:port{endsb}/path/to/repo.git/
> > +- https://host.xz{startsb}:port{endsb}/path/to/repo.git/
> > +- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
> > +- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
> >  - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
> >  - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
> >  - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/
> 
> Do you know if these port specifications do actually work?  Just double
> checking.
>

A quick test with 'netcat':

In xterm 1:

$ nc -l -p 8080

In xterm 2:

$ git clone http://localhost:8080/foo/bar/baz.git

Back in xterm 1 I get:

GET /foo/bar/baz.git/info/refs HTTP/1.1
User-Agent: git/1.6.1.2
Host: localhost:8080
Accept: */*

More testing needed ?

Regards, Stefan

Junio C Hamano· Feb 4, 2009, 21:05 UTC · re: Stefan Näwe · lore

Re: [PATCH v2] urls.txt: document optional port specification in git URLS

Stefan Näwe <stefan.naewe+git@gmail.com> writes:

> More testing needed ?

No, I just was curious.  Thanks for being thorough.

Nicolas Sebrecht· Feb 5, 2009, 08:36 UTC · re: Stefan Naewe · lore

Re: [PATCH] urls.txt: document optional port specification in git URLS

On Wed, Feb 04, 2009 at 12:51:35PM +0100, Stefan Naewe wrote:

>  Documentation/urls.txt |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

[...]

Show 5 quoted lines

> +- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
> +- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
>  - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/

I did not understood. To what does '{startsb}' and '{endsb}' refer ?

-- 
Nicolas Sebrecht

Marius Storm-Olsen· Feb 5, 2009, 09:12 UTC · re: Nicolas Sebrecht · lore

Re: [PATCH] urls.txt: document optional port specification in git URLS

Nicolas Sebrecht said the following on 05.02.2009 09:36:

Show 8 quoted lines

> On Wed, Feb 04, 2009 at 12:51:35PM +0100, Stefan Naewe wrote:
>> +- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
>> +- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
>>  - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
>>  - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
>>  - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/
> 
> I did not understood. To what does '{startsb}' and '{endsb}' refer ?

Commands for the documentation tool
     {startsb} = Start/Left Square Bracket
     {endsb} = End/Right Square Bracket

so, you'll end up seeing
     - git://host.xz[:port]/path/to/repo.git/
     - git://host.xz[:port]/~user/path/to/repo.git/

-- 
.marius [@trolltech.com]
'if you know what you're doing, it's not research'

Stefan Naewe· Feb 5, 2009, 08:41 UTC · lore

Re: [PATCH] urls.txt: document optional port specification in git URLS

(Please don't reply to me only, CC the mailing list)

On 2/5/2009 9:09 AM, Nicolas Sebrecht wrote:

Show 14 quoted lines

> On Wed, Feb 04, 2009 at 12:51:35PM +0100, Stefan Naewe wrote:
> 
>>  Documentation/urls.txt |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> [...]
> 
>> +- git://host.xz{startsb}:port{endsb}/path/to/repo.git/
>> +- git://host.xz{startsb}:port{endsb}/~user/path/to/repo.git/
>>  - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/
>>  - ssh://{startsb}user@{endsb}host.xz/path/to/repo.git/
>>  - ssh://{startsb}user@{endsb}host.xz/~user/path/to/repo.git/
> 
> I did not understood. To what does '{startsb}' and '{endsb}' refer ?

Look at the generated documentation.

Regards, Stefan

-- 
----------------------------------------------------------------
/dev/random says: Useless Invention: Fireproof kindling.