# [PATCH] http-push: add back underscore separator before lock token 2 messages from 2009-02-03 to 2009-02-04. Participants: Tay Ray Chuan, Junio C Hamano. Thread: https://gitlist.dev/t/17528 ## Tay Ray Chuan, 2009-02-03 13:07 Subject: [PATCH] http-push: add back underscore separator before lock token Message-ID: <4988418E.4000808@gmail.com> URL: https://gitlist.dev/e/4988418E.4000808%40gmail.com ``` The patch dated Sat, 31 Jan, "[PATCH] http-push: refactor request url creation" inadvertently removed the underscore separator between the object path and the appended lock token. This patch adds it back. This would be keeping in line with the aforementioned patch's objective of refactoring, without changing the behaviour and effect, of the code. This would also be useful for testing if the lock token has been indeed appended to the object url. Signed-off-by: Tay Ray Chuan --- http-push.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/http-push.c b/http-push.c index 54c62d4..eefd64c 100644 --- a/http-push.c +++ b/http-push.c @@ -557,6 +557,7 @@ static void start_put(struct transfer_request *request) request->dest = strbuf_detach(&buf, NULL); append_remote_object_url(&buf, remote->url, hex, 0); + strbuf_addstr(&buf, "_"); strbuf_addstr(&buf, request->lock->token); request->url = strbuf_detach(&buf, NULL); -- 1.6.1.2.278.g9a9e.dirty ``` ## Junio C Hamano, 2009-02-04 07:47 Subject: Re: [PATCH] http-push: add back underscore separator before lock token Message-ID: <7vskmu3ap5.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vskmu3ap5.fsf%40gitster.siamese.dyndns.org In-Reply-To: <4988418E.4000808@gmail.com> ``` Thanks; I should have caught it while reviewing. ```