# [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI 3 messages from 2009-02-03 to 2009-02-03. Participants: Junio C Hamano, Mike Hommey, Tay Ray Chuan. Thread: https://gitlist.dev/t/17523 ## Junio C Hamano, 2009-02-03 06:45 Subject: [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI Message-ID: <7v8woodnmj.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7v8woodnmj.fsf%40gitster.siamese.dyndns.org ``` Otherwise -Wunused-function (which is implied by -Wall) triggers. Signed-off-by: Junio C Hamano --- I think this patch is probably a bit on the wrong side of the borderline, in that it *happens to be* that get_remote_object_url() is used by nobody in non-multi codepath right now, but it is entirely possible that future code clean-up can benefit from its use. But without this patch,, the file does not compile for me (I compile everything with "-Werror -Wall"). http-push.c | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/http-push.c b/http-push.c index ba5cc32..203c075 100644 --- a/http-push.c +++ b/http-push.c @@ -218,13 +218,6 @@ static void append_remote_object_url(struct strbuf *buf, const char *url, strbuf_addf(buf, "%s", hex+2); } -static char *get_remote_object_url(const char *url, const char *hex, int only_two_digit_prefix) -{ - struct strbuf buf = STRBUF_INIT; - append_remote_object_url(&buf, url, hex, only_two_digit_prefix); - return strbuf_detach(&buf, NULL); -} - static void finish_request(struct transfer_request *request); static void release_request(struct transfer_request *request); @@ -237,6 +230,14 @@ static void process_response(void *callback_data) } #ifdef USE_CURL_MULTI + +static char *get_remote_object_url(const char *url, const char *hex, int only_two_digit_prefix) +{ + struct strbuf buf = STRBUF_INIT; + append_remote_object_url(&buf, url, hex, only_two_digit_prefix); + return strbuf_detach(&buf, NULL); +} + static size_t fwrite_sha1_file(void *ptr, size_t eltsize, size_t nmemb, void *data) { -- 1.6.1.2.343.g53117 ``` ## Mike Hommey, 2009-02-03 06:54 Subject: Re: [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI Message-ID: <20090203065457.GA8466@glandium.org> URL: https://gitlist.dev/e/20090203065457.GA8466%40glandium.org In-Reply-To: <7v8woodnmj.fsf@gitster.siamese.dyndns.org> ``` On Mon, Feb 02, 2009 at 10:45:56PM -0800, Junio C Hamano wrote: > Otherwise -Wunused-function (which is implied by -Wall) triggers. > > Signed-off-by: Junio C Hamano > --- > > I think this patch is probably a bit on the wrong side of the borderline, > in that it *happens to be* that get_remote_object_url() is used by nobody > in non-multi codepath right now, but it is entirely possible that future > code clean-up can benefit from its use. But without this patch,, the file > does not compile for me (I compile everything with "-Werror -Wall"). If I recall correctly, http-push just doesn't work without curl-multi, so the correct fix would be to just disable http-push when USE_CURL_MULTI is undefined. Mike ``` ## Tay Ray Chuan, 2009-02-03 10:40 Subject: Re: [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI Message-ID: URL: https://gitlist.dev/e/be6fef0d0902030240g13672ef4uda2f70443ecfabf7%40mail.gmail.com In-Reply-To: <20090203065457.GA8466@glandium.org> ``` On Tue, Feb 3, 2009 at 2:54 PM, Mike Hommey wrote: > If I recall correctly, http-push just doesn't work without curl-multi, > so the correct fix would be to just disable http-push when > USE_CURL_MULTI is undefined. Indeed, it dies on line 2253 (18d81a). 2252 #ifndef USE_CURL_MULTI 2253 die("git-push is not available for http/https repository when not compiled with USE_CURL_MULTI"); 2254 #endif -- Cheers, Ray Chuan ```