# [PATCH JGIT] fix typo 3 messages from 2009-01-31 to 2009-02-01. Participants: Yann Simon, Robin Rosenberg, Baz. Thread: https://gitlist.dev/t/17479 ## Yann Simon, 2009-01-31 14:26 Subject: [PATCH JGIT] fix typo Message-ID: <1233411967.8213.4.camel@localhost> URL: https://gitlist.dev/e/1233411967.8213.4.camel%40localhost ``` fix a little typo Signed-off-by: Yann Simon --- .../src/org/spearce/jgit/lib/WindowedFile.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java index 5eb8465..1ff8caa 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java @@ -61,7 +61,7 @@ * before any single byte can be accessed. *

*

- * Using a specific MapMode will avoid the complete copy by mmaping in the + * Using a specific MapMode will avoid the complete copy by mapping in the * operating system's file buffers, however this may cause problems if a large * number of windows are being heavily accessed as the Java garbage collector * may not be able to unmap old windows fast enough to permit new windows to be -- 1.6.0.6 ``` ## Robin Rosenberg, 2009-01-31 16:45 Subject: Re: [PATCH JGIT] fix typo Message-ID: <200901311745.16803.robin.rosenberg@dewire.com> URL: https://gitlist.dev/e/200901311745.16803.robin.rosenberg%40dewire.com In-Reply-To: <1233411967.8213.4.camel@localhost> ``` lördag 31 januari 2009 15:26:07 skrev Yann Simon: > fix a little typo > Signed-off-by: Yann Simon > --- > .../src/org/spearce/jgit/lib/WindowedFile.java | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Cleanups are nice too, but please try to follow the existing style when it comes to comments. I don't think we have stated these implicit rules anywhere. - New sentences start with a capital letter. - Don't repeat yourself You do not need a body in the comment if the first line says it all, except the SOB line which technically is part of the body. - Make sure there is an empty line before the SOB line. Cheers, -- robin ``` ## Baz, 2009-02-01 12:42 Subject: Re: [PATCH JGIT] fix typo Message-ID: <2faad3050902010442v6f64b804l79689245c6a60ff4@mail.gmail.com> URL: https://gitlist.dev/e/2faad3050902010442v6f64b804l79689245c6a60ff4%40mail.gmail.com In-Reply-To: <1233411967.8213.4.camel@localhost> ``` 2009/1/31 Yann Simon : > fix a little typo > Signed-off-by: Yann Simon > --- > .../src/org/spearce/jgit/lib/WindowedFile.java | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > index 5eb8465..1ff8caa 100644 > --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowedFile.java > @@ -61,7 +61,7 @@ > * before any single byte can be accessed. > *

> *

> - * Using a specific MapMode will avoid the complete copy by mmaping in > the > + * Using a specific MapMode will avoid the complete copy by mapping in Is this actually a typo? java.nio being used to mmap() files here (see the later use of mmap in this class), its more informative and common to use the double m to describe that. I'd have said the typo was at the end of the comment, ie "fast enough to permit new windows to be mapped." should read "fast enough to permit new windows to be mmapped." > the > * operating system's file buffers, however this may cause problems if > a large > * number of windows are being heavily accessed as the Java garbage > collector > * may not be able to unmap old windows fast enough to permit new > windows to be > -- > 1.6.0.6 > > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ```