threads / patch / 17477

patchsimplify loop with if and do while

Subject: [PATCH JGIT] simplify loop with if and do while

## tl;dr

One message between Jan 31, 2009 and Jan 31, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Yann Simon· Jan 31, 2009, 14:25 UTC · lore
replace if(condition) { do { } while (condition) } by while (condition)
{ }
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
 .../src/org/spearce/jgit/lib/Repository.java       |   18
+++++++-----------
 1 files changed, 7 insertions(+), 11 deletions(-)
Show changes to org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java +7 −11
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
index 038a869..b6efac1 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
@@ -247,11 +247,9 @@ public File toFile(final AnyObjectId objectId) {
 	public boolean hasObject(final AnyObjectId objectId) {
 		final PackFile[] packs = packs();
 		int k = packs.length;
-		if (k > 0) {
-			do {
-				if (packs[--k].hasObject(objectId))
-					return true;
-			} while (k > 0);
+		while (k > 0) {
+			if (packs[--k].hasObject(objectId))
+				return true;
 		}
 		return toFile(objectId).isFile();
 	}
@@ -288,12 +286,10 @@ public ObjectLoader openObject(final WindowCursor
curs, final AnyObjectId id)
 			throws IOException {
 		final PackFile[] packs = packs();
 		int k = packs.length;
-		if (k > 0) {
-			do {
-				final ObjectLoader ol = packs[--k].get(curs, id);
-				if (ol != null)
-					return ol;
-			} while (k > 0);
+		while (k > 0) {
+			final ObjectLoader ol = packs[--k].get(curs, id);
+			if (ol != null)
+				return ol;
 		}
 		try {
 			return new UnpackedObjectLoader(this, id);
-- 
1.6.0.6

← back to recent threads