# [EGIT] Blame functionality update

3 messages from 2009-01-29 to 2009-01-31. Participants: Manuel Woelker, Robin Rosenberg, Shawn O. Pearce.
Thread: https://gitlist.dev/t/17441

## Manuel Woelker, 2009-01-29 17:35

Subject: [EGIT] Blame functionality update
Message-ID: <3d045c7e0901290935l3bddac0emcbaee0b4b2c5695f@mail.gmail.com>
URL: https://gitlist.dev/e/3d045c7e0901290935l3bddac0emcbaee0b4b2c5695f%40mail.gmail.com

```
Hi folks,

quick update about the state of blame functionality in my egit branch
at http://github.com/manuel-woelker/egit/tree/blame
Screen shot here: http://docs.google.com/View?docid=df5rvczr_3f46vd2ds

- Diff support: I changed the IDiff as suggested to work on raw bytes
and IntList's. I also yanked the Diff implementation from wicket and
adapted it for use in jgit. The diff stuff now lives in its own
package. I also added some basic tests to see if plugged diff
implementations conform to the required expectations.

- log support: I added an OriginWalk in the new log package that
traces ancestry of a file though history (including renames and
copying). This might also be neat for the history page, which does not
seem to follow renames at the moment (think "log -C -M"). This is just
a rough sketch atm. Copies are disabled right now, cause the
performance is abysmal, and the current implementation tries to trace
the ancestry of empty lines back to the triassic period. So this could
definitely be optimized. The OriginWalk itself uses RevObject (as
suggested) so it should be a little faster. The implementation
currently traces the different strands of ancestry quite naively,
possibly parsing commits multiple times. This could be improved to a
single pass walk, but this makes the algorithm a little less
straight-forward and I haven't gotten around to that.

- As a result of the the OriginWalk mentioned above, the blame
implementation has been refactored slightly, while still keeping the
basic structure.

- I hooked up the blame functionality to the UI which was easier than
anticipated. I am quite pleased with the result (see screen shot
above). The only thing that proved a little tricky was history and
annotation ruler selection listener notifying each other recursively.
For now I stopped the stack overflow by detecting that recursive call.
If anyone got a better solution just give me a shout.

Feedback, comments and criticism are welcome as always.

Cheers
  - Manuel

```

## Robin Rosenberg, 2009-01-29 20:56

Subject: Re: [EGIT] Blame functionality update
Message-ID: <200901292156.51906.robin.rosenberg.lists@dewire.com>
URL: https://gitlist.dev/e/200901292156.51906.robin.rosenberg.lists%40dewire.com
In-Reply-To: <3d045c7e0901290935l3bddac0emcbaee0b4b2c5695f@mail.gmail.com>

```
torsdag 29 januari 2009 18:35:28 skrev Manuel Woelker:
> Hi folks,
> 
> quick update about the state of blame functionality in my egit branch
> at http://github.com/manuel-woelker/egit/tree/blame
> Screen shot here: http://docs.google.com/View?docid=df5rvczr_3f46vd2ds

Impressive!. Someone's been busy :)

I haven't looked at the code yet but did take it for a ride and it was nice. 

-- robin

```

## Shawn O. Pearce, 2009-01-31 01:26

Subject: Re: [EGIT] Blame functionality update
Message-ID: <20090131012609.GI26880@spearce.org>
URL: https://gitlist.dev/e/20090131012609.GI26880%40spearce.org
In-Reply-To: <200901292156.51906.robin.rosenberg.lists@dewire.com>

```
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> torsdag 29 januari 2009 18:35:28 skrev Manuel Woelker:
> > Hi folks,
> > 
> > quick update about the state of blame functionality in my egit branch
> > at http://github.com/manuel-woelker/egit/tree/blame
> > Screen shot here: http://docs.google.com/View?docid=df5rvczr_3f46vd2ds
> 
> Impressive!. Someone's been busy :)

+1.  This is very nice.
 
-- 
Shawn.

```