# [PATCH] gitweb: ensure the default stylesheet is accessible 3 messages from 2009-01-26 to 2009-01-26. Participants: Giuseppe Bilotta, Jakub Narebski. Thread: https://gitlist.dev/t/17365 ## Giuseppe Bilotta, 2009-01-26 01:28 Subject: [PATCH] gitweb: ensure the default stylesheet is accessible Message-ID: <1232933322-9186-1-git-send-email-giuseppe.bilotta@gmail.com> URL: https://gitlist.dev/e/1232933322-9186-1-git-send-email-giuseppe.bilotta%40gmail.com ``` On some installations the CSS fails to be linked correctly when path_info is enabled, since the link refers to "gitweb.css", whereas it should be "${my_uri}/gitweb.css". Fix by setting the appropriate default in the Makefile. Signed-off-by: Giuseppe Bilotta --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 4ef8234..4f60de9 100644 --- a/Makefile +++ b/Makefile @@ -215,7 +215,7 @@ GITWEB_STRICT_EXPORT = GITWEB_BASE_URL = GITWEB_LIST = GITWEB_HOMETEXT = indextext.html -GITWEB_CSS = gitweb.css +GITWEB_CSS = $${my_uri}/gitweb.css GITWEB_LOGO = git-logo.png GITWEB_FAVICON = git-favicon.png GITWEB_SITE_HEADER = -- 1.5.6.5 ``` ## Jakub Narebski, 2009-01-26 01:48 Subject: Re: [PATCH] gitweb: ensure the default stylesheet is accessible Message-ID: <200901260248.22120.jnareb@gmail.com> URL: https://gitlist.dev/e/200901260248.22120.jnareb%40gmail.com In-Reply-To: <1232933322-9186-1-git-send-email-giuseppe.bilotta@gmail.com> ``` On Mon, 26 Jan 2009, Giuseppe Bilotta wrote: > On some installations the CSS fails to be linked correctly when > path_info is enabled, since the link refers to "gitweb.css", whereas it > should be "${my_uri}/gitweb.css". Fix by setting the appropriate default > in the Makefile. Why "on some installations"? What does "some" mean? I don't think it is something indeterministic: please spell when one can have problems with linking CSS file. Wouldn't it be simpler to deal with problem of base URL when using path_info gitweb URLs to add BASE element to HTML head if we use path_info? Something like: if ($ENV{'PATH_INFO'}) { # $path_info is unfortunately stripped print qq(\n); } somewhere in git_header_html() subroutine? See also comment below. > > Signed-off-by: Giuseppe Bilotta > --- > Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index 4ef8234..4f60de9 100644 > --- a/Makefile > +++ b/Makefile > @@ -215,7 +215,7 @@ GITWEB_STRICT_EXPORT = > GITWEB_BASE_URL = > GITWEB_LIST = > GITWEB_HOMETEXT = indextext.html > -GITWEB_CSS = gitweb.css > +GITWEB_CSS = $${my_uri}/gitweb.css > GITWEB_LOGO = git-logo.png > GITWEB_FAVICON = git-favicon.png It is not the same case for git-logo.png and git-favicon.png as for gitweb.css? If it is not, please explain why in commit message. If it is, then your patch is only partial solution to path_info problem. > GITWEB_SITE_HEADER = > -- > 1.5.6.5 > > -- Jakub Narebski Poland ``` ## Giuseppe Bilotta, 2009-01-26 11:35 Subject: Re: [PATCH] gitweb: ensure the default stylesheet is accessible Message-ID: URL: https://gitlist.dev/e/cb7bb73a0901260335n3cc53295m162ca56810702596%40mail.gmail.com In-Reply-To: <200901260248.22120.jnareb@gmail.com> ``` On Mon, Jan 26, 2009 at 2:48 AM, Jakub Narebski wrote: > On Mon, 26 Jan 2009, Giuseppe Bilotta wrote: > >> On some installations the CSS fails to be linked correctly when >> path_info is enabled, since the link refers to "gitweb.css", whereas it >> should be "${my_uri}/gitweb.css". Fix by setting the appropriate default >> in the Makefile. > > Why "on some installations"? What does "some" mean? I don't think it > is something indeterministic: please spell when one can have problems > with linking CSS file. The truth is, I haven't the slightest idea. It works fine on my machine, it doesn't without the patch on ruby-rbot.org, but I really don't know why. > Wouldn't it be simpler to deal with problem of base URL when using > path_info gitweb URLs to add BASE element to HTML head if we use > path_info? Something like: > > if ($ENV{'PATH_INFO'}) { # $path_info is unfortunately stripped > print qq(\n); > } > > somewhere in git_header_html() subroutine? Ah, this might work. I'll test it. > It is not the same case for git-logo.png and git-favicon.png as for > gitweb.css? If it is not, please explain why in commit message. > If it is, then your patch is only partial solution to path_info > problem. Oh, interesting, true, I hadn't noticed. I'll look into the base thing. -- Giuseppe "Oblomov" Bilotta ```