threads / patch / 17363

patchgit-svn: fix memory leak when checking for empty symlinks

Subject: [PATCH] git-svn: fix memory leak when checking for empty symlinks

## tl;dr

One message between Jan 26, 2009 and Jan 26, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Eric Wong· Jan 26, 2009, 01:15 UTC · lore
By enforcing SVN::Pool usage when calling get_file once again.

This regression was introduced with the reintroduction of SVN::Ra::get_file() usage in dbc6c74d0858d77e61e092a48d467e725211f8e9

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 git-svn.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Show changes to git-svn.perl +2 −1
diff --git a/git-svn.perl b/git-svn.perl
index d4cb538..5d39b39 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -4021,7 +4021,8 @@ my ($ra_invalid, $can_do_switch, %ignored_err, $RA);
 BEGIN {
 	# enforce temporary pool usage for some simple functions
 	no strict 'refs';
-	for my $f (qw/rev_proplist get_latest_revnum get_uuid get_repos_root/) {
+	for my $f (qw/rev_proplist get_latest_revnum get_uuid get_repos_root
+	              get_file/) {
 		my $SUPER = "SUPER::$f";
 		*$f = sub {
 			my $self = shift;
-- 
Eric Wong

← back to recent threads