# [PATCH] Makefile: Use libc strlcpy on OSX 3 messages from 2009-01-24 to 2009-01-24. Participants: Benjamin Kramer, Junio C Hamano. Thread: https://gitlist.dev/t/17338 ## Benjamin Kramer, 2009-01-24 15:41 Subject: [PATCH] Makefile: Use libc strlcpy on OSX Message-ID: <7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com> URL: https://gitlist.dev/e/7f978c810901240741k201f954dx1c0470186094ae24%40mail.gmail.com ``` OSX supports strlcpy(3) since 10.2 so we don't need to use our own. Signed-off-by: Benjamin Kramer --- Makefile | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b4d9cb4..4c9aab5 100644 --- a/Makefile +++ b/Makefile @@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin) ifneq ($(shell expr "$(uname_R)" : '9\.'),2) OLD_ICONV = UnfortunatelyYes endif - NO_STRLCPY = YesPlease NO_MEMMEM = YesPlease THREADED_DELTA_SEARCH = YesPlease endif -- 1.6.1.285.g3454 ``` ## Junio C Hamano, 2009-01-24 18:39 Subject: Re: [PATCH] Makefile: Use libc strlcpy on OSX Message-ID: <7vfxj8o8fq.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vfxj8o8fq.fsf%40gitster.siamese.dyndns.org In-Reply-To: <7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com> ``` Benjamin Kramer writes: > OSX supports strlcpy(3) since 10.2 so we don't need > to use our own. How does your patch to Makefile refrain from kicking in for people with OSX older than 10.2, so that their builds are not broken? > > Signed-off-by: Benjamin Kramer > --- > Makefile | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index b4d9cb4..4c9aab5 100644 > --- a/Makefile > +++ b/Makefile > @@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin) > ifneq ($(shell expr "$(uname_R)" : '9\.'),2) > OLD_ICONV = UnfortunatelyYes > endif > - NO_STRLCPY = YesPlease > NO_MEMMEM = YesPlease > THREADED_DELTA_SEARCH = YesPlease > endif ``` ## Benjamin Kramer, 2009-01-24 18:51 Subject: Re: [PATCH] Makefile: Use libc strlcpy on OSX Message-ID: <7f978c810901241051m752a0b97s8ce76c3d2ece0695@mail.gmail.com> URL: https://gitlist.dev/e/7f978c810901241051m752a0b97s8ce76c3d2ece0695%40mail.gmail.com In-Reply-To: <7vfxj8o8fq.fsf@gitster.siamese.dyndns.org> ``` On Sat, Jan 24, 2009 at 19:39, Junio C Hamano wrote: > How does your patch to Makefile refrain from kicking in for people with > OSX older than 10.2, so that their builds are not broken? I'm not even sure anyone uses <= 10.1 nowadays. But of course you're right, I'll write a better patch. -- Benjamin ```