# [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler 2 messages from 2009-01-19 to 2009-01-20. Participants: Markus Heidelberg, David Aguilar. Thread: https://gitlist.dev/t/17261 ## Markus Heidelberg, 2009-01-19 23:41 Subject: [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler Message-ID: <200901200041.18793.markus.heidelberg@web.de> URL: https://gitlist.dev/e/200901200041.18793.markus.heidelberg%40web.de ``` When interrupting git-difftool with Ctrl-C, the output of this echo command led to having the cursor at the beginning of the line below the shell prompt. Signed-off-by: Markus Heidelberg --- David, have you intentionally added this 'echo', did it fix anything for you? contrib/difftool/git-difftool-helper | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper index a2eb59b..0c48506 100755 --- a/contrib/difftool/git-difftool-helper +++ b/contrib/difftool/git-difftool-helper @@ -32,7 +32,6 @@ cleanup_temp_files () { # This is called when users Ctrl-C out of git-difftool-helper sigint_handler () { - echo cleanup_temp_files exit 1 } -- 1.6.1.216.g3acd ``` ## David Aguilar, 2009-01-20 03:04 Subject: Re: [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler Message-ID: <402731c90901191904l217d6bdenf33f02033519c731@mail.gmail.com> URL: https://gitlist.dev/e/402731c90901191904l217d6bdenf33f02033519c731%40mail.gmail.com In-Reply-To: <200901200041.18793.markus.heidelberg@web.de> ``` On Mon, Jan 19, 2009 at 3:41 PM, Markus Heidelberg wrote: > When interrupting git-difftool with Ctrl-C, the output of this echo > command led to having the cursor at the beginning of the line below the > shell prompt. > > Signed-off-by: Markus Heidelberg > --- > > David, have you intentionally added this 'echo', did it fix > anything for you? I think you're right in that we're better off without the echo. There wasn't really any reason for it to be there. > > contrib/difftool/git-difftool-helper | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper > index a2eb59b..0c48506 100755 > --- a/contrib/difftool/git-difftool-helper > +++ b/contrib/difftool/git-difftool-helper > @@ -32,7 +32,6 @@ cleanup_temp_files () { > > # This is called when users Ctrl-C out of git-difftool-helper > sigint_handler () { > - echo > cleanup_temp_files > exit 1 > } > -- > 1.6.1.216.g3acd > > -- David ```