# log-tree.c: date hardwired 6 messages from 2009-01-13 to 2009-01-18. Participants: jidanni@jidanni.org, Alex Riesen, Sitaram Chamarty, Junio C Hamano. Thread: https://gitlist.dev/t/17138 ## jidanni@jidanni.org, 2009-01-13 03:13 Subject: log-tree.c: date hardwired Message-ID: <87r637oq41.fsf@jidanni.org> URL: https://gitlist.dev/e/87r637oq41.fsf%40jidanni.org ``` In log-tree.c: printf("From %s Mon Sep 17 00:00:00 2001\n", name); Wouldn't it be more aesthetically pleasing to use current local or UTC time? Or at least comment in the code that the date is hardwired like that in the fear that otherwise people will think it is the actual commit time. No, I can't think of any other tool that hardwires the From separators they produce. ``` ## jidanni@jidanni.org, 2009-01-17 23:27 Subject: Re: log-tree.c: date hardwired Message-ID: <87fxjhcy3i.fsf@jidanni.org> URL: https://gitlist.dev/e/87fxjhcy3i.fsf%40jidanni.org In-Reply-To: <87r637oq41.fsf@jidanni.org> ``` Can I get a go-ahead from somebody for me to begin work on implementing a fix? (Yes, trivial.) >>>>> "j" == jidanni writes: j> In log-tree.c: printf("From %s Mon Sep 17 00:00:00 2001\n", name); j> Wouldn't it be more aesthetically pleasing to use current local or UTC time? j> Or at least comment in the code that the date is hardwired like that j> in the fear that otherwise people will think it is the actual commit time. j> No, I can't think of any other tool that hardwires the From separators j> they produce. ``` ## Alex Riesen, 2009-01-17 23:38 Subject: Re: log-tree.c: date hardwired Message-ID: <81b0412b0901171538l5e9fb66bh862c9b7a125fc98f@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0901171538l5e9fb66bh862c9b7a125fc98f%40mail.gmail.com In-Reply-To: <87fxjhcy3i.fsf@jidanni.org> ``` 2009/1/18 : > Can I get a go-ahead from somebody for me to begin work on implementing a fix? No. Try and guess why ``` ## jidanni@jidanni.org, 2009-01-17 23:50 Subject: Re: log-tree.c: date hardwired Message-ID: <87bpu5cx10.fsf@jidanni.org> URL: https://gitlist.dev/e/87bpu5cx10.fsf%40jidanni.org In-Reply-To: <81b0412b0901171538l5e9fb66bh862c9b7a125fc98f@mail.gmail.com> ``` Perhaps a comment could be added to the code as to the reason a date or that certain date is hardwired. Any reason would be satisfactory. ``` ## Sitaram Chamarty, 2009-01-18 00:40 Subject: Re: log-tree.c: date hardwired Message-ID: URL: https://gitlist.dev/e/slrngn4uk0.r31.sitaramc%40sitaramc.homelinux.net In-Reply-To: <81b0412b0901171538l5e9fb66bh862c9b7a125fc98f@mail.gmail.com> ``` On 2009-01-17, Alex Riesen wrote: > 2009/1/18 : >> Can I get a go-ahead from somebody for me to begin work >> on implementing a fix? > > No. Try and guess why OK, I'll bite... Because it's only used as the date for the mbox format leader line, and not an actual email (RFC 822/2822) header line? And in that format it represents "delivery date", which is irrelevant for stuff you're generating to be sent out anyway, meaning this line doesn't actually get sent out to anyone when you mail your patches, so we don't care what it is. I can't think of anything else, so if it isn't that please do tell. Not that I cared about it before, but once someone says "try and guess why" it somehow becomes important :-) ``` ## Junio C Hamano, 2009-01-18 00:52 Subject: Re: log-tree.c: date hardwired Message-ID: <7vbpu55tc7.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vbpu55tc7.fsf%40gitster.siamese.dyndns.org In-Reply-To: <87fxjhcy3i.fsf@jidanni.org> ``` jidanni@jidanni.org writes: > Can I get a go-ahead from somebody for me to begin work on implementing a fix? No, don't "fix" it. Please keep it as a known constant. That way, you can come up with an /etc/magic entry to teach find(1) that it is not just a random mailbox but is an output from format-patch. ```