threads / patch / 17112

patchnotes: fix core.notesRef documentation

Subject: [PATCH next] notes: fix core.notesRef documentation

## tl;dr

3 messages between Jan 12, 2009 and Jan 13, 2009. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Thomas Rast· Jan 12, 2009, 14:16 UTC · lore

The path format was inconsistent with the one used in git-notes.sh: it supposedly split the sha1 in the same 2/38 format that .git/objects uses, but the code uses the full sha1 without a path separator.

While at it, also fix a grammatical error.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
 Documentation/config.txt |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
Show changes to Documentation/config.txt +4 −6
diff --git a/Documentation/config.txt b/Documentation/config.txt
index acfeb77..348da77 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -424,15 +424,13 @@ overlapping IO's.
 
 core.notesRef::
 	When showing commit messages, also show notes which are stored in
-	the given ref.  This ref is expected to contain paths of the form
-	??/*, where the directory name consists of the first two
-	characters of the commit name, and the base name consists of
-	the remaining 38 characters.
+	the given ref.  This ref is expected to contain files named
+	after the full SHA-1 of the commit they annotate.
 +
-If such a path exists in the given ref, the referenced blob is read, and
+If such a file exists in the given ref, the referenced blob is read, and
 appended to the commit message, separated by a "Notes:" line.  If the
 given ref itself does not exist, it is not an error, but means that no
-notes should be print.
+notes should be printed.
 +
 This setting defaults to "refs/notes/commits", and can be overridden by
 the `GIT_NOTES_REF` environment variable.
-- 
tg: (1063ea4..) t/notes-doc-fix (depends on: next)
Johannes Schindelin· Jan 12, 2009, 14:41 UTC · re: Thomas Rast · lore

Re: [PATCH next] notes: fix core.notesRef documentation

Hi,
On Mon, 12 Jan 2009, Thomas Rast wrote:
Show 7 quoted lines
> The path format was inconsistent with the one used in git-notes.sh: it
> supposedly split the sha1 in the same 2/38 format that .git/objects
> uses, but the code uses the full sha1 without a path separator.
> 
> While at it, also fix a grammatical error.
> 
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Thanks, Dscho

← back to recent threads