threads / bug / 17022

BUG?? INSTALL MAKEFILE

Subject: BUG?? INSTALL MAKEFILE

## tl;dr

8 messages between Jan 6, 2009 and Jan 7, 2009.

replies: 7people: 5as markdown or json

Lars Sadau· Jan 6, 2009, 13:26 UTC · lore
Hallo,

i'm a brand-new git user. Just one minute ago I wanted to install git in my home directory. The INSTALL file says type simply "make install", but the makefile does a global installation.

Lars
Matthieu Moy· Jan 6, 2009, 14:56 UTC · re: Lars Sadau · lore

Re: BUG?? INSTALL MAKEFILE

Lars Sadau <lars@sadau-online.de> writes:
Show 5 quoted lines
> Hallo,
>
> i'm a brand-new git user. Just one minute ago I wanted to install git in
> my home directory. The INSTALL file says type simply "make install", but
> the makefile does a global installation.
I was going to write:
  Either run ./configure --prefix=$HOME/wherever/you/want or edit the
  prefix variable in config.mak.
but then realized that prefix is set to $(HOME) by default. Are you
sure you didn't edit the Makefile or run any sort of ./configure
before "make install" ?
  
-- 
Matthieu
Mike Ralphson· Jan 6, 2009, 15:22 UTC · re: Matthieu Moy · lore

Re: BUG?? INSTALL MAKEFILE

2009/1/6 Matthieu Moy <Matthieu.Moy@imag.fr>
Show 13 quoted lines
> Lars Sadau <lars@sadau-online.de> writes:
> > i'm a brand-new git user. Just one minute ago I wanted to install git in
> > my home directory. The INSTALL file says type simply "make install", but
> > the makefile does a global installation.
>
> I was going to write:
>
>  Either run ./configure --prefix=$HOME/wherever/you/want or edit the
>  prefix variable in config.mak.
>
> but then realized that prefix is set to $(HOME) by default. Are you
> sure you didn't edit the Makefile or run any sort of ./configure
> before "make install" ?
Or run 'make' as root, as well as 'make install'?
Mike
Ted Pavlic· Jan 6, 2009, 16:26 UTC · re: Matthieu Moy · lore

Re: BUG?? INSTALL MAKEFILE

> but then realized that prefix is set to $(HOME) by default. Are you
> sure you didn't edit the Makefile or run any sort of ./configure
> before "make install" ?
After doing a
	git clean -f
in my local git repo, I notice that:
	config.mak.autogen
still exists, and inside it:
	prefix = /usr/local

That file is included in the Makefile *after* prefix is set, and so if it's not updated, the Makefile will default to /usr/local.

According to the INSTALL doc, the default prefix should be ~. However, this is certainly not the case. Either the INSTALL doc needs to be updated or a new default config.mak.autogen needs to be checked in (or perhaps config.mak.autogen needs to be omitted from the repo?).

--Ted
-- 
Ted Pavlic <ted@tedpavlic.com>
Matthieu Moy· Jan 6, 2009, 17:17 UTC · re: Ted Pavlic · lore

Re: BUG?? INSTALL MAKEFILE

Ted Pavlic <ted@tedpavlic.com> writes:
> According to the INSTALL doc, the default prefix should be ~.

I didn't read that in INSTALL. What I read is that if I only run "make install", the prefix is $HOME, which is true. Now, ./configure uses a default value which is not the one of the Makefile, but that's another point.

-- 
Matthieu
Lars Sadau· Jan 7, 2009, 10:44 UTC · re: Matthieu Moy · lore

Re: BUG?? INSTALL MAKEFILE

Matthieu Moy <Matthieu.Moy <at> imag.fr> writes:
> 
> Ted Pavlic <ted <at> tedpavlic.com> writes:
> 
> > According to the INSTALL doc, the default prefix should be ~.
I am the same opinion
Show 5 quoted lines
> I didn't read that in INSTALL. What I read is that if I only run "make
> install", the prefix is $HOME, which is true. Now, ./configure uses a
> default value which is not the one of the Makefile, but that's another
> point.
> 
May be not, confuses newbies.

------ Lars

Daniel Barkalow· Jan 6, 2009, 17:24 UTC · re: Ted Pavlic · lore

Re: BUG?? INSTALL MAKEFILE

On Tue, 6 Jan 2009, Ted Pavlic wrote:
Show 7 quoted lines
> > but then realized that prefix is set to $(HOME) by default. Are you
> > sure you didn't edit the Makefile or run any sort of ./configure
> > before "make install" ?
> 
> After doing a
> 
> 	git clean -f
You need a "git clean -fx"
> According to the INSTALL doc, the default prefix should be ~. However, this is
> certainly not the case. Either the INSTALL doc needs to be updated or a new
> default config.mak.autogen needs to be checked in (or perhaps
> config.mak.autogen needs to be omitted from the repo?).

It's omitted from the repo, but it's in .gitignore so "git clean" doesn't remove it unless you tell it to remove ignored files.

	-Daniel
*This .sig left intentionally blank*
Ted Pavlic· Jan 6, 2009, 19:44 UTC · re: Ted Pavlic · lore

Re: BUG?? INSTALL MAKEFILE

> 	git clean -f
DOH. I meant to do
	git clean -fx

(or just a git ls-files). That config.mak.autogen is certainly not checked into the repo, and a quick test confirms that "make install" certainly does set prefix to the home directory.

That being said, I'm sure that in the recent past I had to use configure to install git into home directories.

--Ted
-- 
Ted Pavlic <ted@tedpavlic.com>

← back to recent threads