threads / patch / 16992

patchFix sourcing "test-lib.sh" using dash shell in "t3003-ls-files-narrow-match.sh"

Subject: [PATCH] Fix sourcing "test-lib.sh" using dash shell in "t3003-ls-files-narrow-match.sh"

## tl;dr

3 messages between Jan 5, 2009 and Jan 7, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Christian Couder· Jan 5, 2009, 13:30 UTC · lore

dash barfs, on my old Ubuntu box, when "test-lib.sh" is sourced without "./".

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 t/t3003-ls-files-narrow-match.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
	This patch applies to "pu".
Show changes to t/t3003-ls-files-narrow-match.sh +1 −1
diff --git a/t/t3003-ls-files-narrow-match.sh b/t/t3003-ls-files-narrow-match.sh
index 9879525..b576bca 100755
--- a/t/t3003-ls-files-narrow-match.sh
+++ b/t/t3003-ls-files-narrow-match.sh
@@ -2,7 +2,7 @@
 
 test_description='This test is for narrow spec matching'
 
-. test-lib.sh
+. ./test-lib.sh
 
 D="$(cd ..;pwd)"/t3003
 
-- 
1.6.1.143.gfd590.dirty
Junio C Hamano· Jan 6, 2009, 08:18 UTC · re: Christian Couder · lore

Re: [PATCH] Fix sourcing "test-lib.sh" using dash shell in "t3003-ls-files-narrow-match.sh"

Christian Couder <chriscool@tuxfamily.org> writes:
Show 9 quoted lines
> dash barfs, on my old Ubuntu box, when "test-lib.sh" is sourced
> without "./".
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  t/t3003-ls-files-narrow-match.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> 	This patch applies to "pu".

Thanks; I hope you don't mind squashing this in to 'Introduce "sparse patterns"'.

Christian Couder· Jan 7, 2009, 07:29 UTC · re: Junio C Hamano · lore

Re: [PATCH] Fix sourcing "test-lib.sh" using dash shell in "t3003-ls-files-narrow-match.sh"

Le mardi 6 janvier 2009, Junio C Hamano a écrit :
Show 13 quoted lines
> Christian Couder <chriscool@tuxfamily.org> writes:
> > dash barfs, on my old Ubuntu box, when "test-lib.sh" is sourced
> > without "./".
> >
> > Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> > ---
> >  t/t3003-ls-files-narrow-match.sh |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > 	This patch applies to "pu".
>
> Thanks; I hope you don't mind squashing this in to 'Introduce "sparse
> patterns"'.
No problem.

Thanks, Christian.

← back to recent threads