# [CLEANUP PATCH] show : reuse pp_user_info() instead of duplicating code 2 messages from 2009-01-02 to 2009-01-06. Participants: Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/16971 ## Johannes Schindelin, 2009-01-02 18:08 Subject: [CLEANUP PATCH] show : reuse pp_user_info() instead of duplicating code Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0901021717350.27818%40racer ``` We used to extract the tagger information "by hand" in "git show ", but the function pp_user_info() already does that. Even better: it respects the commit_format and date_format specified by the user. Signed-off-by: Johannes Schindelin --- Just a little cleanup, as I tripped over that part of Git's source. builtin-log.c | 21 ++++++--------------- 1 files changed, 6 insertions(+), 15 deletions(-) diff --git a/builtin-log.c b/builtin-log.c index 99d1137..bc4e1e9 100644 --- a/builtin-log.c +++ b/builtin-log.c @@ -249,22 +249,13 @@ int cmd_whatchanged(int argc, const char **argv, const char *prefix) static void show_tagger(char *buf, int len, struct rev_info *rev) { - char *email_end, *p; - unsigned long date; - int tz; + struct strbuf out = STRBUF_INIT; - email_end = memchr(buf, '>', len); - if (!email_end) - return; - p = ++email_end; - while (isspace(*p)) - p++; - date = strtoul(p, &p, 10); - while (isspace(*p)) - p++; - tz = (int)strtol(p, NULL, 10); - printf("Tagger: %.*s\nDate: %s\n", (int)(email_end - buf), buf, - show_date(date, tz, rev->date_mode)); + pp_user_info("Tagger", rev->commit_format, &out, buf, rev->date_mode, + git_log_output_encoding ? + git_log_output_encoding: git_commit_encoding); + printf("%s\n", out.buf); + strbuf_release(&out); } static int show_object(const unsigned char *sha1, int show_tag_object, -- 1.6.1.rc3.224.g95ac9 ``` ## Junio C Hamano, 2009-01-06 08:18 Subject: Re: [CLEANUP PATCH] show : reuse pp_user_info() instead of duplicating code Message-ID: <7vsknwlufa.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vsknwlufa.fsf%40gitster.siamese.dyndns.org In-Reply-To: ``` Thanks. ```