# [PATCH] gitweb: use href() when generating URLs in OPML

3 messages from 2009-01-02 to 2009-01-06. Participants: Giuseppe Bilotta, Jakub Narebski, Junio C Hamano.
Thread: https://gitlist.dev/t/16962

## Giuseppe Bilotta, 2009-01-02 12:15

Subject: [PATCH] gitweb: use href() when generating URLs in OPML
Message-ID: <1230898528-24187-1-git-send-email-giuseppe.bilotta@gmail.com>
URL: https://gitlist.dev/e/1230898528-24187-1-git-send-email-giuseppe.bilotta%40gmail.com

```
Since the OPML project list view was hand-coding the RSS and HTML URLs,
it didn't respect global options such as use_pathinfo. Make it use
href() to ensure consistency with the rest of the gitweb setup.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index fa7d8ad..b164001 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -6146,8 +6146,8 @@ XML
 		}
 
 		my $path = esc_html(chop_str($proj{'path'}, 25, 5));
-		my $rss  = "$my_url?p=$proj{'path'};a=rss";
-		my $html = "$my_url?p=$proj{'path'};a=summary";
+		my $rss  = href('project' => $proj{'path'}, 'action' => 'rss', -full => 1);
+		my $html = href('project' => $proj{'path'}, 'action' => 'summary', -full => 1);
 		print "<outline type=\"rss\" text=\"$path\" title=\"$path\" xmlUrl=\"$rss\" htmlUrl=\"$html\"/>\n";
 	}
 	print <<XML;
-- 
1.5.6.5

```

## Jakub Narebski, 2009-01-02 13:09

Subject: Re: [PATCH] gitweb: use href() when generating URLs in OPML
Message-ID: <200901021409.07695.jnareb@gmail.com>
URL: https://gitlist.dev/e/200901021409.07695.jnareb%40gmail.com
In-Reply-To: <1230898528-24187-1-git-send-email-giuseppe.bilotta@gmail.com>

```
Giuseppe Bilotta wrote:
> Since the OPML project list view was hand-coding the RSS and HTML URLs,
> it didn't respect global options such as use_pathinfo. Make it use
> href() to ensure consistency with the rest of the gitweb setup.

Good catch. I guess it was before href(..., -full=>1)...

> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

Acked-by: Jakub Narebski <jnareb@gmail.com>

> ---
>  gitweb/gitweb.perl |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index fa7d8ad..b164001 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6146,8 +6146,8 @@ XML
>  		}
>  
>  		my $path = esc_html(chop_str($proj{'path'}, 25, 5));
> -		my $rss  = "$my_url?p=$proj{'path'};a=rss";
> -		my $html = "$my_url?p=$proj{'path'};a=summary";
> +		my $rss  = href('project' => $proj{'path'}, 'action' => 'rss', -full => 1);
> +		my $html = href('project' => $proj{'path'}, 'action' => 'summary', -full => 1);
>  		print "<outline type=\"rss\" text=\"$path\" title=\"$path\" xmlUrl=\"$rss\" htmlUrl=\"$html\"/>\n";
>  	}
>  	print <<XML;
> -- 
> 1.5.6.5
> 
> 

-- 
Jakub Narebski
Poland

```

## Junio C Hamano, 2009-01-06 08:17

Subject: Re: [PATCH] gitweb: use href() when generating URLs in OPML
Message-ID: <7vaba4n908.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vaba4n908.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <200901021409.07695.jnareb@gmail.com>

```
Thanks, both; applied.

```