# [PATCH] Git.pm: let a false Directory parameter (such as 0) be used correctly by the constructor 2 messages from 2009-01-02 to 2009-01-02. Participants: Philippe Bruhat (BooK). Thread: https://gitlist.dev/t/16957 ## Philippe Bruhat (BooK), 2009-01-02 08:47 Subject: [PATCH] Git.pm: let a false Directory parameter (such as 0) be used correctly by the constructor Message-ID: <1230886057-23994-1-git-send-email-book@cpan.org> URL: https://gitlist.dev/e/1230886057-23994-1-git-send-email-book%40cpan.org ``` Signed-off-by: Philippe Bruhat (BooK) --- perl/Git.pm | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/perl/Git.pm b/perl/Git.pm index 8392a68..ad0f530 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -166,11 +166,12 @@ sub repository { } } - if (not defined $opts{Repository} and not defined $opts{WorkingCopy}) { - $opts{Directory} ||= '.'; + if (not defined $opts{Repository} and not defined $opts{WorkingCopy} + and not defined $opts{Directory}) { + $opts{Directory} = '.'; } - if ($opts{Directory}) { + if (defined $opts{Directory}) { -d $opts{Directory} or throw Error::Simple("Directory not found: $!"); my $search = Git->repository(WorkingCopy => $opts{Directory}); -- 1.6.0.3.517.g759a ``` ## Philippe Bruhat (BooK), 2009-01-02 09:09 Subject: Re: [PATCH] Git.pm: let a false Directory parameter (such as 0) be used correctly by the constructor Message-ID: <20090102090940.GA23222@plop> URL: https://gitlist.dev/e/20090102090940.GA23222%40plop In-Reply-To: <1230886057-23994-1-git-send-email-book@cpan.org> ``` On Fri, Jan 02, 2009 at 09:47:37AM +0100, Philippe Bruhat (BooK) wrote: > Signed-off-by: Philippe Bruhat (BooK) > --- > perl/Git.pm | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) Please ignore, I forgot half of the the requested changes. Sorry for the noise. -- Philippe Bruhat (BooK) Mankind is the story of the same mistakes in different places. (Moral from Groo #1 (Image)) ```