# [PATCH] gitrepository-layout: No longer first two letters. Also add "down". 19 messages from 2008-12-26 to 2008-12-29. Participants: jidanni@jidanni.org, Junio C Hamano, Nanako Shiraishi, Boyd Stephen Smith Jr., Sverre Rabbelier. Thread: https://gitlist.dev/t/16874 ## jidanni@jidanni.org, 2008-12-26 16:43 Subject: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: URL: https://gitlist.dev/e/E1LGFoE-0001EZ-0F%40jidanni.org ``` Signed-off-by: jidanni diff --git a/gitrepository-layout.txt b/gitrepository-layout.txt index 03c52ff..81103fc 100644 --- a/gitrepository-layout.txt +++ b/gitrepository-layout.txt @@ -46,6 +46,4 @@ objects/[0-9a-f][0-9a-f]:: - Traditionally, each object is stored in its own file. - They are split into 256 subdirectories using the first - two letters from its object name to keep the number of - directory entries `objects` directory itself needs to - hold. Objects found here are often called 'unpacked' - (or 'loose') objects. + Traditionally, each object is stored in its own file. They are + split into 256 subdirectories to keep the number of directory + entries `objects` directory itself needs to hold down. Objects + found here are often called 'unpacked' (or 'loose') objects. -- 1.5.6.5 ``` ## Junio C Hamano, 2008-12-26 20:07 Subject: Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: <7veizuog2z.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7veizuog2z.fsf%40gitster.siamese.dyndns.org In-Reply-To: ``` jidanni@jidanni.org writes: > Signed-off-by: jidanni First off, when I tried to respond to your message, I got this: Cc: undisclosed-recipients:; which I had to edit it to point at the list. I think you did "Bcc: git@vger.kernel.org" without any explicit recipient; please don't. It wastes everybody's time. Second, please realize that the Subject: line is one of the most important piece of information in your patch submission. It is used as the summary of what this change is about in the shortlog output. 2 months from now, do you think anybody (other than you) can guess what the "first two letters" is about among 400 other changes? I would have preferred the Subject: and the commit log message like this for this patch: Subject: [PATCH] Fix description of objects/??/ directories in the repository-layout doc These fan-out directories are no longer first two letters. Also fix a sentence that meant to say "keep something down" but forgot "down". That is, summarize what this patch is about on Subject: line, and explain why the change is a good idea (in other words, why the current one is bad) in the commit log message. I agree with the "down" fix; thanks for catching this grammatical and semantic error. I however do not understand the reason behind the former "two letters" change. When creating a new object, the filename to hold it when its object name is e.g. 92b35d66d0e335771c2e4a4a79f95adb844b1f91 (that's a tag object for v1.6.1 if anybody cares) is computed by taking its first two letters "92" and using that to choose ".git/object/92" as the containing "fan-out" directory. The file in that directory is named using the remainder of the object name. The entry in the repository layout document explains what the directories with two-letter names you find in objects/ directory are, and I do not see a reason why you want to say "no longer first two letters". Their names still are, and very likely continue to be, two-letter long. Maybe I misunderstood what you wanted to say by "no longer...". Did you mean (unlike the sample commit log message I suggested above): Subject: [PATCH] Fix description of objects/??/ directories in the repository-layout doc Do not say first two letters anymore. Also fix a sentence that meant to say "keep something down" but forgot "down". If that is the case, please justify why you think it is better not to say "first two letters" the documentation. Thanks. ``` ## jidanni@jidanni.org, 2008-12-26 20:19 Subject: Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: <87skoau1su.fsf@jidanni.org> URL: https://gitlist.dev/e/87skoau1su.fsf%40jidanni.org In-Reply-To: <7veizuog2z.fsf@gitster.siamese.dyndns.org> ``` >>>>> "JCH" == Junio C Hamano writes: JCH> If that is the case, please justify why you think it is better not to say JCH> "first two letters" the documentation. OK, I saw $ ls 3d 05a66c3.. 189066f.. If it were the first to letters, it would be $ ls 3d 3d05a66c3.. 3d189066f.. Ah, you mean it snaps them off to form the directory name?! OK, please note that. As far as all your other points and messed up To:, OK, next time I will do better. ``` ## Junio C Hamano, 2008-12-26 21:30 Subject: Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: <7vmyeilj3z.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmyeilj3z.fsf%40gitster.siamese.dyndns.org In-Reply-To: <87skoau1su.fsf@jidanni.org> ``` jidanni@jidanni.org writes: >>>>>> "JCH" == Junio C Hamano writes: > > JCH> If that is the case, please justify why you think it is better not to say > JCH> "first two letters" the documentation. > OK, I saw > $ ls 3d > 05a66c3.. > 189066f.. > If it were the first to letters, it would be > $ ls 3d > 3d05a66c3.. > 3d189066f.. > Ah, you mean it snaps them off to form the directory name?! OK, please > note that. If you read the description again, you will notice that the entry explains what these directories are; it is not a description about the files in these directories. > As far as all your other points and messed up To:, OK, next time I will do better. When sending the fixed-up patch, please send it in an applicable form. I do not know how you stripped "Documentation/" from the front, but your patch was against {a,b}/gitrepository-layout.txt. Thanks. ``` ## Nanako Shiraishi, 2008-12-26 22:02 Subject: Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: <20081227070232.6117@nanako3.lavabit.com> URL: https://gitlist.dev/e/20081227070232.6117%40nanako3.lavabit.com In-Reply-To: ``` Quoting jidanni@jidanni.org: > Signed-off-by: jidanni Didn't you mean "Signed-off-by: 積丹尼 "? -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ ``` ## jidanni@jidanni.org, 2008-12-26 22:42 Subject: commit.template Message-ID: <87tz8qsgn2.fsf_-_@jidanni.org> URL: https://gitlist.dev/e/87tz8qsgn2.fsf_-_%40jidanni.org In-Reply-To: <20081227070232.6117@nanako3.lavabit.com> ``` NS> Didn't you mean "Signed-off-by: 積丹尼 "? No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org", but apparently 1) man git-config mentions commit.template Specify a file to use as the template for new commit messages. but doesn't mention what file is being used presently, so one can know what to adjust. 2) .git/hooks/commit-msg etc. don't seem to control that line. 3) Making a line without a name would probably break other things. ``` ## jidanni@jidanni.org, 2008-12-26 23:08 Subject: Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: <87lju2sfft.fsf@jidanni.org> URL: https://gitlist.dev/e/87lju2sfft.fsf%40jidanni.org In-Reply-To: <7vmyeilj3z.fsf@gitster.siamese.dyndns.org> ``` OK, the two letters are related by an algorithm. ``` ## Junio C Hamano, 2008-12-26 23:44 Subject: Re: commit.template Message-ID: <7v8wq2lcwq.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7v8wq2lcwq.fsf%40gitster.siamese.dyndns.org In-Reply-To: <87tz8qsgn2.fsf_-_@jidanni.org> ``` jidanni@jidanni.org writes: > NS> Didn't you mean "Signed-off-by: 積丹尼 "? > > No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org", That won't fly well, provided if you want your patches in git.git tree. ``` ## Boyd Stephen Smith Jr., 2008-12-26 23:50 Subject: Re: commit.template Message-ID: <200812261750.12204.bss@iguanasuicide.net> URL: https://gitlist.dev/e/200812261750.12204.bss%40iguanasuicide.net In-Reply-To: <87tz8qsgn2.fsf_-_@jidanni.org> ``` On Friday 2008 December 26 16:42:09 jidanni@jidanni.org wrote: > NS> Didn't you mean "Signed-off-by: 積丹尼 "? > > No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org", > but apparently > 1) man git-config mentions > commit.template > Specify a file to use as the template for new commit messages. > > but doesn't mention what file is being used presently, so one can know > what to adjust. git commit --help tells how this configuration option is used, in the documentation of the "-t" option. > 3) Making a line without a name would probably break other things. Well, then use your legal name -- unicode is allowed. -- Boyd Stephen Smith Jr. ,= ,-_-. =. bss@iguanasuicide.net ((_/)o o(\_)) ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-' http://iguanasuicide.net/ \_/ ``` ## jidanni@jidanni.org, 2008-12-27 00:01 Subject: Re: commit.template Message-ID: <87hc4qscz5.fsf@jidanni.org> URL: https://gitlist.dev/e/87hc4qscz5.fsf%40jidanni.org In-Reply-To: <200812261750.12204.bss@iguanasuicide.net> ``` OK, both >> 1) man git-config mentions >> commit.template and BSS> git commit --help tells how this configuration option is used, in the BSS> documentation of the "-t" option. should >> mention what file is being used presently as one needs a template in order to modify a template... in case someone one day wants to. Not me. I'm happy already. ``` ## Nanako Shiraishi, 2008-12-27 00:07 Subject: Re: commit.template Message-ID: <20081227090727.6117@nanako3.lavabit.com> URL: https://gitlist.dev/e/20081227090727.6117%40nanako3.lavabit.com In-Reply-To: <87tz8qsgn2.fsf_-_@jidanni.org> ``` Quoting jidanni@jidanni.org: > NS> Didn't you mean "Signed-off-by: 積丹尼 "? > > No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org", I think everybody on the list now understands that you desperately want to be different. I think it would be beneficial for you to try making a difference in areas that matter, instead of just trying to be different in how your name is spelled. Just my two yen ;-) -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ ``` ## Junio C Hamano, 2008-12-27 00:13 Subject: Re: commit.template Message-ID: <7vwsdmjwzr.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vwsdmjwzr.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20081227090727.6117@nanako3.lavabit.com> ``` Nanako Shiraishi writes: > Quoting jidanni@jidanni.org: > >> NS> Didn't you mean "Signed-off-by: 積丹尼 "? >> >> No. I want in fact just to use "Signed-off-by: jidanni@jidanni.org", > > I think everybody on the list now understands that you desperately want to be different. I think it would be beneficial for you to try making a difference in areas that matter, instead of just trying to be different in how your name is spelled. > > Just my two yen ;-) Even though I soft-of-kind-of understand that you are frustrated for getting that response after offering an advice to satisfy his earlier wish: "Thanks but I want to be http://zh.wikipedia.org/wiki/積丹尼" made in $gmane/103591, you do not sound so harsh and play a bad girl. Be civil and friendly around here, please... ``` ## Junio C Hamano, 2008-12-27 00:16 Subject: Re: commit.template Message-ID: <7vr63ujwvg.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vr63ujwvg.fsf%40gitster.siamese.dyndns.org In-Reply-To: <7vwsdmjwzr.fsf@gitster.siamese.dyndns.org> ``` Junio C Hamano writes: > made in $gmane/103591, you do not sound so harsh and play a bad girl. Sorry, I meant "do not have to"... ``` ## Boyd Stephen Smith Jr., 2008-12-27 00:53 Subject: Re: commit.template Message-ID: <200812261853.55464.bss@iguanasuicide.net> URL: https://gitlist.dev/e/200812261853.55464.bss%40iguanasuicide.net In-Reply-To: <87hc4qscz5.fsf@jidanni.org> ``` On Friday 2008 December 26 18:01:18 jidanni@jidanni.org wrote: > OK, both > > >> 1) man git-config mentions > >> commit.template > > and > BSS> git commit --help tells how this configuration option is used, in the > BSS> documentation of the "-t" option. > should > > >> mention what file is being used presently There is no file being used presently. With the "-m" or "-F" option, no template is ever used. Without those options, either the argument to "-t" or the value of commit.template is used in that order; the editor is invoked on that. Finally if neither of those are defined the editor is invoked on a new, empty file. > as one needs a template in order to modify a template. You aren't modifying the template with commit.template or "-t", you are specifying one. You can create one from scratch in your editor of choice. -- Boyd Stephen Smith Jr. ,= ,-_-. =. bss@iguanasuicide.net ((_/)o o(\_)) ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-' http://iguanasuicide.net/ \_/ ``` ## jidanni@jidanni.org, 2008-12-27 01:04 Subject: Re: commit.template Message-ID: <874p0qsa2h.fsf@jidanni.org> URL: https://gitlist.dev/e/874p0qsa2h.fsf%40jidanni.org In-Reply-To: <200812261853.55464.bss@iguanasuicide.net> ``` OK, but there should be a reference to any %escapes available in templates, etc. Or say the template is purely and additional ".signature" style file that will be inserted at some certain spot... ``` ## Boyd Stephen Smith Jr., 2008-12-27 01:48 Subject: Re: commit.template Message-ID: <200812261948.58032.bss@iguanasuicide.net> URL: https://gitlist.dev/e/200812261948.58032.bss%40iguanasuicide.net In-Reply-To: <874p0qsa2h.fsf@jidanni.org> ``` On Friday 2008 December 26 19:04:06 jidanni@jidanni.org wrote: > OK, but there should be a reference to any %escapes available in > templates, etc. There are none, at least not right now. > Or say the template is purely and additional ".signature" style file > that will be inserted at some certain spot... There's what it says: "Use the contents of the given file as the initial version of the commit message. The editor is invoked and you can make subsequent changes. [...] This overrides the commit.template configuration variable." -- 'git commit --help' What isn't clear about that? It's not an *extra* file; it is the template (what you start with) for commit messages. -- Boyd Stephen Smith Jr. ,= ,-_-. =. bss@iguanasuicide.net ((_/)o o(\_)) ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-' http://iguanasuicide.net/ \_/ ``` ## jidanni@jidanni.org, 2008-12-27 02:00 Subject: Re: commit.template Message-ID: <87r63uqswe.fsf@jidanni.org> URL: https://gitlist.dev/e/87r63uqswe.fsf%40jidanni.org In-Reply-To: <200812261948.58032.bss@iguanasuicide.net> ``` I see, it's not replacing something current. It is adding something extra. OK, would have never guessed. OK, stopping here. ``` ## Sverre Rabbelier, 2008-12-28 17:00 Subject: Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: URL: https://gitlist.dev/e/bd6139dc0812280900t12189c6anb583033e52a5b027%40mail.gmail.com In-Reply-To: <20081227070232.6117@nanako3.lavabit.com> ``` On Fri, Dec 26, 2008 at 16:02, Nanako Shiraishi wrote: > Quoting jidanni@jidanni.org: > >> Signed-off-by: jidanni > > Didn't you mean "Signed-off-by: 積丹尼 "? Be nice, they are obviously a bit peculiar about their name/sign-off name :). -- Cheers, Sverre Rabbelier ``` ## Nanako Shiraishi, 2008-12-29 08:52 Subject: Re: [PATCH] gitrepository-layout: No longer first two letters. Also add "down". Message-ID: <20081229175252.6117@nanako3.lavabit.com> URL: https://gitlist.dev/e/20081229175252.6117%40nanako3.lavabit.com In-Reply-To: ``` Quoting "Sverre Rabbelier" : > On Fri, Dec 26, 2008 at 16:02, Nanako Shiraishi wrote: >> Quoting jidanni@jidanni.org: >> >>> Signed-off-by: jidanni >> >> Didn't you mean "Signed-off-by: 積丹尼 "? > > Be nice, they are obviously a bit peculiar about their name/sign-off name :). If you are telling me that I said something un-nice, I apologize. I did not mean to offend anybody. But I do not understand. Who do you mean by they in your sentence? > -- > Cheers, > > Sverre Rabbelier > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ ```