# [PATCH] connect.c: stricter port validation, silence compiler warning

1 messages from 2008-12-21 to 2008-12-21. Participants: René Scharfe.
Thread: https://gitlist.dev/t/16814

## René Scharfe, 2008-12-21 01:12

Subject: [PATCH] connect.c: stricter port validation, silence compiler warning
Message-ID: <1229821931.31765.12.camel@ubuntu.ubuntu-domain>
URL: https://gitlist.dev/e/1229821931.31765.12.camel%40ubuntu.ubuntu-domain

```
In addition to checking if the provided port is numeric, also check
that the string isn't empty and that the port number is within the
valid range.  Incidentally, this silences a compiler warning about
ignoring strtol's return value.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 connect.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/connect.c b/connect.c
index 584e04c..2f55ad2 100644
--- a/connect.c
+++ b/connect.c
@@ -480,8 +480,8 @@ char *get_port(char *host)
 	char *p = strchr(host, ':');
 
 	if (p) {
-		strtol(p+1, &end, 10);
-		if (*end == '\0') {
+		long port = strtol(p + 1, &end, 10);
+		if (end != p + 1 && *end == '\0' && 0 <= port && port < 65536) {
 			*p = '\0';
 			return p+1;
 		}
-- 
1.6.1.rc3.52.g589372

```