threads / patch / 16806

patchhandle_remote_ls_ctx can parsing href starting at http://

Subject: [PATCH] handle_remote_ls_ctx can parsing href starting at http://

## tl;dr

2 messages between Dec 20, 2008 and Dec 21, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Kirill A. Korinskiy· Dec 20, 2008, 11:23 UTC · lore

The program call remote_ls() to get remote objects over http; handle_remote_ls_ctx() is used to parse it's response to populated "struct remote_ls_ctx" that is returned from remote_ls().

The handle_remote_ls_ctx() function assumed that the server will returned local path in href field, but RFC 4918 demand of support full URI (http://localhost/repo.git for example).

This resulted in push failure (git-http-push ask server PROPFIND /repo.git/alhost:8080/repo.git/refs/) when a server returned full URI.

Signed-off-by: Kirill A. Korinskiy <catap@catap.ru>
---
 http-push.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)
Show changes to http-push.c +10 −6
diff --git a/http-push.c b/http-push.c
index 7c6460919bf3eba10c46cede11ffdd9c53fd2dd2..abf0269e0fe20a43a6247fc7584dc2d58322a8fa 100644
--- a/http-push.c
+++ b/http-push.c
@@ -87,6 +87,7 @@ static struct object_list *objects;
 struct repo
 {
 	char *url;
+	char *path;
 	int path_len;
 	int has_info_refs;
 	int can_update_info_refs;
@@ -1424,9 +1425,10 @@ static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed)
 				ls->userFunc(ls);
 			}
 		} else if (!strcmp(ctx->name, DAV_PROPFIND_NAME) && ctx->cdata) {
-			ls->dentry_name = xmalloc(strlen(ctx->cdata) -
+			char *path = strstr(ctx->cdata, remote->path);
+			ls->dentry_name = xmalloc(strlen(path) -
 						  remote->path_len + 1);
-			strcpy(ls->dentry_name, ctx->cdata + remote->path_len);
+			strcpy(ls->dentry_name, path + remote->path_len);
 		} else if (!strcmp(ctx->name, DAV_PROPFIND_COLLECTION)) {
 			ls->dentry_flags |= IS_DIR;
 		}
@@ -2206,10 +2208,11 @@ int main(int argc, char **argv)
 		if (!remote->url) {
 			char *path = strstr(arg, "//");
 			remote->url = arg;
+			remote->path_len = strlen(arg);
 			if (path) {
-				path = strchr(path+2, '/');
-				if (path)
-					remote->path_len = strlen(path);
+				remote->path = strchr(path+2, '/');
+				if (remote->path)
+					remote->path_len = strlen(remote->path);
 			}
 			continue;
 		}
@@ -2238,8 +2241,9 @@ int main(int argc, char **argv)
 		rewritten_url = xmalloc(strlen(remote->url)+2);
 		strcpy(rewritten_url, remote->url);
 		strcat(rewritten_url, "/");
+		remote->path = rewritten_url + (remote->path - remote->url);
+		remote->path_len++;
 		remote->url = rewritten_url;
-		++remote->path_len;
 	}
 
 	/* Verify DAV compliance/lock support */

-- 
1.5.6.5
Junio C Hamano· Dec 21, 2008, 09:42 UTC · re: Kirill A. Korinskiy · lore

Re: [PATCH] handle_remote_ls_ctx can parsing href starting at http://

"Kirill A. Korinskiy" <catap@catap.ru> writes:
Show 7 quoted lines
> The program call remote_ls() to get remote objects over http;
> handle_remote_ls_ctx() is used to parse it's response to populated
> "struct remote_ls_ctx" that is returned from remote_ls().
>
> The handle_remote_ls_ctx() function assumed that the server will
> returned local path in href field, but RFC 4918 demand of support full
> URI (http://localhost/repo.git for example).

Do you mean "the client should support both server-relative '/repo.git' and full 'http://localhost/repo.git'", or "the client should reject '/repo.git' and insist on full 'http://localhost/repo.git'"? I am guessing the former but it is not quite clear. Where in 4918 is this specified?

> This resulted in push failure (git-http-push ask server
> PROPFIND /repo.git/alhost:8080/repo.git/refs/) when a server returned
> full URI.
This is an interesting but confusing example.
Do you mean the bug is:
 (1) the client asks PROPFIND /repo.git/;
 (2) the server gives http://localhost/repo.git/refs back;
 (3) the client incorrectly assumes that the response would start with
     /repo.git/ (e.g. "/repo.git/refs"), so strips 10 bytes from the
     beginning of this result and uses the remainder as the "new"
     information to dig deeper; i.e. "alhost/repo.git/refs";
 (4) the new part is appended to the original path and the client forms
     the next request "PROPFIND /repo.git/alhost/repo.git/refs/";
 (5) instead, the client should strip the proto://host part (if exists)
     and request "PROPFIND /repo.git/refs/".
Show 8 quoted lines
> @@ -1424,9 +1425,10 @@ static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed)
>  				ls->userFunc(ls);
>  			}
>  		} else if (!strcmp(ctx->name, DAV_PROPFIND_NAME) && ctx->cdata) {
> -			ls->dentry_name = xmalloc(strlen(ctx->cdata) -
> +			char *path = strstr(ctx->cdata, remote->path);
> +			ls->dentry_name = xmalloc(strlen(path) -
>  						  remote->path_len + 1);

What if you are talking to http://repo.git/repo.git/? Doesn't this strstr() misbehave? Instead, shouldn't you be checking if the response begins with proto://host/ and stripping it iff so?

← back to recent threads