# Remove feature_grep in gitweb?

4 messages from 2008-12-07 to 2008-12-07. Participants: Matt Kraai, Jakub Narebski, Junio C Hamano.
Thread: https://gitlist.dev/t/16621

## Matt Kraai, 2008-12-07 05:22

Subject: Remove feature_grep in gitweb?
Message-ID: <20081207052230.GD4357@ftbfs.org>
URL: https://gitlist.dev/e/20081207052230.GD4357%40ftbfs.org

```
Howdy,

A feature_grep subroutine is defined in gitweb.perl, but unlike the
other feature_* subroutines there, it doesn't appear to be used
anywhere.  Should it be removed?

-- 
Matt                                                 http://ftbfs.org/

```

## Jakub Narebski, 2008-12-07 09:36

Subject: [PATCH] gitweb: Make project specific override for 'grep' feature work
Message-ID: <20081207093447.25785.41811.stgit@localhost.localdomain>
URL: https://gitlist.dev/e/20081207093447.25785.41811.stgit%40localhost.localdomain
In-Reply-To: <20081207052230.GD4357@ftbfs.org>

```
The 'grep' feature was marked in the comments as having project
specific config, but it lacked 'sub' key required for it to work.

Kind-of-Noticed-by: Matt Kraai <kraai@ftbfs.org>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Matt Kraai wrote:

> A feature_grep subroutine is defined in gitweb.perl, but unlike the
> other feature_* subroutines there, it doesn't appear to be used
> anywhere.  Should it be removed?

No, it was oversight; it should be used in setting up 'grep' %feature
configuration, see below.

Thanks for catching this.

 gitweb/gitweb.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 95988fb..9517392 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -241,6 +241,7 @@ our %feature = (
 	# $feature{'grep'}{'override'} = 1;
 	# and in project config gitweb.grep = 0|1;
 	'grep' => {
+		'sub' => \&feature_grep,
 		'override' => 0,
 		'default' => [1]},
 

```

## Junio C Hamano, 2008-12-07 10:52

Subject: Re: [PATCH] gitweb: Make project specific override for 'grep' feature work
Message-ID: <7vljuscl4v.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vljuscl4v.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <20081207093447.25785.41811.stgit@localhost.localdomain>

```
Thanks, both.  This should go to maint, right?

```

## Jakub Narebski, 2008-12-07 11:16

Subject: Re: [PATCH] gitweb: Make project specific override for 'grep' feature work
Message-ID: <200812071216.31850.jnareb@gmail.com>
URL: https://gitlist.dev/e/200812071216.31850.jnareb%40gmail.com
In-Reply-To: <7vljuscl4v.fsf@gitster.siamese.dyndns.org>

```
On Sun, 7 Dec 2008, Junio C Hamano wrote:

> Thanks, both.  This should go to maint, right?
> 

Yes, I think so.
-- 
Jakub Narebski
Poland

```