so that non-CSS browsers fall back to preserving the line boundaries (which is what is making it look so unbearable in your text browser). But it is definitely something to be fixed in asciidoc, not in the git documentation. -Peff ``` ## jidanni@jidanni.org, 2009-01-08 19:36 Subject: Re: X-Debbugs-Cc didn't make it to git@vger.kernel.org Message-ID: <87ljtlk2sl.fsf@jidanni.org> URL: https://gitlist.dev/e/87ljtlk2sl.fsf%40jidanni.org In-Reply-To: <87ej0qf3gx.fsf@jidanni.org> ``` >>>>> "j" == jidanni writes: j> Bummer, on j> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507475 j> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507476 j> I used X-Debbugs-Cc, and it says Report forwarded to git@vger.kernel.org j> but I don't see them here on nntp:gmane.comp.version-control.git . j> Perhaps they got filtered out? Why of course, $ git checkout origin/todo $ GET 'http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=2;mbox=yes;bug=507475'|./taboo.perl 43 Delivered-To: submit@bugs.debian.org matches /^[-\w_]*:/ && m!Delivered-To:! # These are Majordomo's global majordomo.cf as used at # vger.kernel.org. So forget about any X-Debbugs-Cc reaching any kernel.org list. ``` ## Jonathan Nieder, 2010-08-20 05:04 Subject: Re: user-manual.html invalid HTML Message-ID: <20100820050401.GC25013@burratino> URL: https://gitlist.dev/e/20100820050401.GC25013%40burratino In-Reply-To: <87hc5ahzy8.fsf@jidanni.org> ``` Hi, Sorry for the long silence. Jeff King wrote: > On Fri, Dec 12, 2008 at 04:32:15AM +0800, jidanni@jidanni.org wrote: [user-manual.html lacks a !DOCTYPE declaration] > > The versions I build locally have: > > "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> > > in each HTML file, which is added by asciidoc. Maybe the package you > are looking at was built with an older version of asciidoc that doesn't > do this (I don't actually know the history of this feature, but it seems > to me that this is something asciidoc should be doing, not git). It looks like the HTML for user-manual.html (unlike the reference manual and other articles) is not generated by asciidoc after all; instead, the rule in Documentation/Makefile uses xsltproc directly to convert the asciidoc-generated XML to HTML. Apparently the caller is supposed to set the chunker.output.doctype-public parameter. http://www.sagehill.net/docbookxsl/Chunking.html#OutputDoctype Maybe something as simple as this would work. -- 8< -- Subject: Documentation: set a !DOCTYPE for user manual asciidoc already takes care of including a doctype for most of the HTML documentation, but the user manual which is processed with docbook-xsl directly lacks one (at least with Debian docbook-xsl 1.75.2+dfsg-5). This makes it harder to automatically validate the HTML. Reported-by: 積丹尼 Signed-off-by: Jonathan Nieder --- diff --git a/Documentation/docbook.xsl b/Documentation/docbook.xsl index 9a6912c..da8b05b 100644 --- a/Documentation/docbook.xsl +++ b/Documentation/docbook.xsl @@ -1,5 +1,8 @@ - + -- ``` ## Jeff King, 2010-08-21 06:21 Subject: Re: user-manual.html invalid HTML Message-ID: <20100821062122.GA28735@coredump.intra.peff.net> URL: https://gitlist.dev/e/20100821062122.GA28735%40coredump.intra.peff.net In-Reply-To: <20100820050401.GC25013@burratino> ``` On Fri, Aug 20, 2010 at 12:04:02AM -0500, Jonathan Nieder wrote: > > The versions I build locally have: > > > > > "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> > > > > in each HTML file, which is added by asciidoc. Maybe the package you > > are looking at was built with an older version of asciidoc that doesn't > > do this (I don't actually know the history of this feature, but it seems > > to me that this is something asciidoc should be doing, not git). > > It looks like the HTML for user-manual.html (unlike the reference > manual and other articles) is not generated by asciidoc after all; > instead, the rule in Documentation/Makefile uses xsltproc directly to > convert the asciidoc-generated XML to HTML. Thanks for tracking this down. > Apparently the caller is supposed to set the > chunker.output.doctype-public parameter. > http://www.sagehill.net/docbookxsl/Chunking.html#OutputDoctype Your patch works fine for me, though I am using the exact same toolchain as you. I have no idea if older docbook's will work less well. > + + encoding="UTF-8" indent="no" > + doctype-public="-//W3C//DTD HTML 4.01//EN" > + doctype-system="http://www.w3.org/TR/html4/strict.dtd" /> My asciidoc-generated pages are xhtml. We are using "html/docbook.xsl" from docbook, and now "xhtml", so probably some form of html is right. But is html4 strict right? With nothing else to go on, it seems a good guess to me, but I'm wondering if you actually found the answer somewhere. Also, while testing your patch, I found and fixed the following buglet: -- >8 -- Subject: [PATCH] docs: fix Makefile dependency for user manual We use our custom xsl file to build the user manual, so make sure we depend on it. We don't use it anywhere else, so we can stick it straight in the rule. Signed-off-by: Jeff King --- Documentation/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/Makefile b/Documentation/Makefile index a4c4063..e117bc4 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -279,7 +279,7 @@ $(patsubst %,%.html,$(API_DOCS) technical/api-index): %.html : %.txt XSLT = docbook.xsl XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css -user-manual.html: user-manual.xml +user-manual.html: user-manual.xml $(XSLT) $(QUIET_XSLTPROC)$(RM) $@+ $@ && \ xsltproc $(XSLTOPTS) -o $@+ $(XSLT) $< && \ mv $@+ $@ -- 1.7.2.2.350.g9c7e ``` ## Junio C Hamano, 2010-08-22 07:23 Subject: Re: user-manual.html invalid HTML Message-ID: <7vvd735cwr.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vvd735cwr.fsf%40alter.siamese.dyndns.org In-Reply-To: <20100821062122.GA28735@coredump.intra.peff.net> ``` Jeff King writes: > Subject: [PATCH] docs: fix Makefile dependency for user manual Thanks. ```