threads / patch / 16556

patchDo not append a new line to the backwards compat files (bug #12656)

Subject: [StGit PATCH] Do not append a new line to the backwards compat files (bug #12656)

## tl;dr

2 messages between Dec 2, 2008 and Dec 2, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Catalin Marinas· Dec 2, 2008, 14:38 UTC · lore

Since the multiline argument wasn't passed to the utils.write_string() function when writing the compatibility description file from the new infrastructure, any older command like push would have committed these new lines.

Signed-off-by: Catalin Marinas <catalin.marinas@gmail.com>
---
 stgit/lib/stack.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to stgit/lib/stack.py +1 −1
diff --git a/stgit/lib/stack.py b/stgit/lib/stack.py
index 47679b6..a72ee22 100644
--- a/stgit/lib/stack.py
+++ b/stgit/lib/stack.py
@@ -58,7 +58,7 @@ class Patch(object):
         write('authdate', d.author.date)
         write('commname', d.committer.name)
         write('commemail', d.committer.email)
-        write('description', d.message)
+        write('description', d.message, multiline = True)
         write('log', write_patchlog().sha1)
         write('top', new_commit.sha1)
         write('bottom', d.parent.sha1)
Karl Hasselström· Dec 2, 2008, 15:39 UTC · re: Catalin Marinas · lore

Re: [StGit PATCH] Do not append a new line to the backwards compat files (bug #12656)

On 2008-12-02 14:38:39 +0000, Catalin Marinas wrote:
Show 6 quoted lines
> Since the multiline argument wasn't passed to the
> utils.write_string() function when writing the compatibility
> description file from the new infrastructure, any older command like
> push would have committed these new lines.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@gmail.com>
Acked-by: Karl Hasselström <kha@treskal.com>
Thanks.
-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

← back to recent threads