threads / patch / 16552

patcht4030-diff-textconv: Make octal escape sequence more portable

Subject: [PATCH] t4030-diff-textconv: Make octal escape sequence more portable

## tl;dr

3 messages between Dec 2, 2008 and Dec 3, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Johannes Sixt· Dec 2, 2008, 08:31 UTC · lore
From: Johannes Sixt <j6t@kdbg.org>

There are printfs around that do not grok '\1', but need '\01'. Discovered on AIX 4.3.x.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
	I found no other instance of printf backslash-nonzero.
 t/t4030-diff-textconv.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to t/t4030-diff-textconv.sh +1 −1
diff --git a/t/t4030-diff-textconv.sh b/t/t4030-diff-textconv.sh
index 03ba26a..4e961df 100755
--- a/t/t4030-diff-textconv.sh
+++ b/t/t4030-diff-textconv.sh
@@ -29,7 +29,7 @@ test_expect_success 'setup binary file with history' '
 	printf "\\0\\n" >file &&
 	git add file &&
 	git commit -m one &&
-	printf "\\1\\n" >>file &&
+	printf "\\01\\n" >>file &&
 	git add file &&
 	git commit -m two
 '

-- 
1.6.1.rc1.5.gf691f
Jeff King· Dec 2, 2008, 12:54 UTC · re: Johannes Sixt · lore

Re: [PATCH] t4030-diff-textconv: Make octal escape sequence more portable

On Tue, Dec 02, 2008 at 09:31:01AM +0100, Johannes Sixt wrote:
> There are printfs around that do not grok '\1', but need '\01'.
> Discovered on AIX 4.3.x.
Whee. Your fix works fine on my platforms (Solaris + FreeBSD).
> 	I found no other instance of printf backslash-nonzero.
Me either.
-Peff

← back to recent threads