# [PATCH 3/5] Removed unused variables prev and next.

2 messages from 2008-11-27 to 2008-11-28. Participants: William Pursell, Junio C Hamano.
Thread: https://gitlist.dev/t/16506

## William Pursell, 2008-11-27 21:10

Subject: [PATCH 3/5] Removed unused variables prev and next.
Message-ID: <492F0CBF.3010202@gmail.com>
URL: https://gitlist.dev/e/492F0CBF.3010202%40gmail.com

```


---
  git-add--interactive.perl |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index b530597..0d51cb2 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -878,7 +878,7 @@ sub patch_update_file {
  	$ix = 0;

  	while (1) {
-		my ($prev, $next, $commands, $undecided, $i);
+		my ($commands, $undecided, $i);
  		$commands = 'ynad';

  		if ($num <= $ix) {
@@ -886,7 +886,6 @@ sub patch_update_file {
  		}
  		for ($i = 0; $i < $ix; $i++) {
  			if (!defined $hunk[$i]{USE}) {
-				$prev = 1;
  				$commands .= 'k';
  				last;
  			}
@@ -896,7 +895,6 @@ sub patch_update_file {
  		}
  		for ($i = $ix + 1; $i < $num; $i++) {
  			if (!defined $hunk[$i]{USE}) {
-				$next = 1;
  				$commands .= 'j';
  				last;
  			}
-- 
1.6.0.4.782.geea74.dirty


-- 
William Pursell

```

## Junio C Hamano, 2008-11-28 01:28

Subject: Re: [PATCH 3/5] Removed unused variables prev and next.
Message-ID: <7vabbkabar.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vabbkabar.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <492F0CBF.3010202@gmail.com>

```
Hmm, I was hoping that use of these instead of $other =~ /,k/ might be
more efficient some day, but Ok.

```