threads / patch / 16476

patchtg export: implement skipping empty patches for quilt mode

Subject: [PATCH] tg export: implement skipping empty patches for quilt mode

## tl;dr

3 messages between Nov 26, 2008 and Nov 26, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Uwe Kleine-König· Nov 26, 2008, 12:13 UTC · lore

addionally fix the README item for skipping the export of empty patches not to need an option (-n) as this should be the default.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 README       |    2 +-
 tg-export.sh |   12 ++++++++----
 2 files changed, 9 insertions(+), 5 deletions(-)
Show changes to 2 files +9 −5

README, tg-export.sh

diff --git a/README b/README
index 5bfe3ee..9b92d43 100644
--- a/README
+++ b/README
@@ -414,7 +414,7 @@ tg export
 	TODO: Make stripping of non-essential headers configurable
 	TODO: Make stripping of [PATCH] and other prefixes configurable
 	TODO: --mbox option for other mode of operation
-	TODO: -n option to prevent exporting of empty patches
+	TODO: prevent exporting of empty patches
 	TODO: -a option to export all branches
 	TODO: For quilt exporting, use a temporary branch and remove it when
 	      done - this would allow producing conflict-less series
diff --git a/tg-export.sh b/tg-export.sh
index 52af88d..f133fb8 100644
--- a/tg-export.sh
+++ b/tg-export.sh
@@ -140,10 +140,14 @@ quilt()
 		return
 	fi
 
-	echo "Exporting $_dep"
-	mkdir -p "$(dirname "$filename")"
-	$tg patch "$_dep" >"$filename"
-	echo "$_dep.diff -p1" >>"$output/series"
+	if branch_empty "$_dep"; then
+		echo "Skip empty patch $_dep";
+	else
+		echo "Exporting $_dep"
+		mkdir -p "$(dirname "$filename")"
+		$tg patch "$_dep" >"$filename"
+		echo "$_dep.diff -p1" >>"$output/series"
+	fi
 }
 
 
-- 
1.5.6.5
martin f krafft· Nov 26, 2008, 20:39 UTC · re: Uwe Kleine-König · lore

Re: [PATCH] tg export: implement skipping empty patches for quilt mode

also sprach Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [2008.11.26.1313 +0100]:
> addionally fix the README item for skipping the export of empty patches
> not to need an option (-n) as this should be the default.
[...]
> -	TODO: -n option to prevent exporting of empty patches
> +	TODO: prevent exporting of empty patches
Is it still a TODO? Looks like your patch fixes it, no?
-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems
 
"the difference between genius and stupidity
 is that genius has it's limits."
                                                    -- albert einstein
Uwe Kleine-König· Nov 26, 2008, 21:19 UTC · re: martin f krafft · lore

Re: [PATCH] tg export: implement skipping empty patches for quilt mode

Hi,
On Wed, Nov 26, 2008 at 09:39:59PM +0100, martin f krafft wrote:
Show 8 quoted lines
> also sprach Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [2008.11.26.1313 +0100]:
> > addionally fix the README item for skipping the export of empty patches
> > not to need an option (-n) as this should be the default.
> [...]
> > -	TODO: -n option to prevent exporting of empty patches
> > +	TODO: prevent exporting of empty patches
> 
> Is it still a TODO? Looks like your patch fixes it, no?
No, it's still a TODO for the collapse driver.

Best regards Uwe

← back to recent threads