threads / patch / 16432

patchgitk: map / to focus the search box

Subject: [PATCH] gitk: map / to focus the search box

## tl;dr

3 messages between Nov 23, 2008 and Dec 2, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Giuseppe Bilotta· Nov 23, 2008, 17:01 UTC · lore

The / key is often used to initiate searches (less, vim, some web
browsers). We change the binding for the / (slash) key from 'find next'
to 'focus the search box' to follow this convention.
---
 gitk-git/gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to gitk-git/gitk +1 −1

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 6b671a6..8b60632 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2271,7 +2271,7 @@ proc makewindow {} {
     bindkey b prevfile
     bindkey d "$ctext yview scroll 18 units"
     bindkey u "$ctext yview scroll -18 units"
-    bindkey / {dofind 1 1}
+    bindkey / {focus $fstring}
     bindkey <Key-Return> {dofind 1 1}
     bindkey ? {dofind -1 1}
     bindkey f nextfile

-- 
1.5.6.5

Paul Mackerras· Dec 1, 2008, 22:33 UTC · re: Giuseppe Bilotta · lore

Re: [PATCH] gitk: map / to focus the search box

Giuseppe Bilotta writes:

> The / key is often used to initiate searches (less, vim, some web
> browsers). We change the binding for the / (slash) key from 'find next'
> to 'focus the search box' to follow this convention.

I think that's reasonable, but the patch needs to update the key bindings help text as well.

Thanks, Paul.

Giuseppe Bilotta· Dec 2, 2008, 01:19 UTC · re: Paul Mackerras · lore

The / key is often used to initiate searches (less, vim, some web browsers). We change the binding for the / (slash) key from 'find next' to 'focus the search box' to follow this convention.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---

Like this?

 gitk-git/gitk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to gitk-git/gitk +2 −2

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 6b671a6..0c0350b 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2271,7 +2271,7 @@ proc makewindow {} {
     bindkey b prevfile
     bindkey d "$ctext yview scroll 18 units"
     bindkey u "$ctext yview scroll -18 units"
-    bindkey / {dofind 1 1}
+    bindkey / {focus $fstring}
     bindkey <Key-Return> {dofind 1 1}
     bindkey ? {dofind -1 1}
     bindkey f nextfile
@@ -2652,7 +2652,7 @@ proc keys {} {
 [mc "<%s-F>		Find" $M1T]
 [mc "<%s-G>		Move to next find hit" $M1T]
 [mc "<Return>	Move to next find hit"]
-[mc "/		Move to next find hit, or redo find"]
+[mc "/		Focus the search box"]
 [mc "?		Move to previous find hit"]
 [mc "f		Scroll diff view to next file"]
 [mc "<%s-S>		Search for next hit in diff view" $M1T]

-- 
1.5.6.5