threads / patch / 16423

patchRe: [TopGit PATCH] put die() messages to stderr

Subject: Re: [TopGit PATCH] put die() messages to stderr

## tl;dr

4 messages between Nov 21, 2008 and Nov 21, 2008. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Bert Wesarg· Nov 21, 2008, 10:05 UTC · lore

[TopGit PATCH] put die() messages to stderr

Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
---
 tg.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to tg.sh +1 −1
diff --git a/tg.sh b/tg.sh
index 4dcc15e..21294f9 100644
--- a/tg.sh
+++ b/tg.sh
@@ -13,7 +13,7 @@ info()
 
 die()
 {
-	info "fatal: $*"
+	info "fatal: $*" >&2
 	exit 1
 }
 

-- 
tg: (f17218e..) bw/die-to-stderr (depends on: master)
martin f krafft· Nov 21, 2008, 12:36 UTC · re: Bert Wesarg · lore
also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1105 +0100]:
> -	info "fatal: $*"
> +	info "fatal: $*" >&2
Shouldn't info also output to stderr?
-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"i have made good judgments in the past.
 i have made good judgments in the future."
                                                      - george w. bush
 
spamtraps: madduck.bogus@madduck.net
Marc Weber· Nov 21, 2008, 13:28 UTC · re: martin f krafft · lore
On Fri, Nov 21, 2008 at 01:36:54PM +0100, martin f krafft wrote:
Show 5 quoted lines
> also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1105 +0100]:
> > -	info "fatal: $*"
> > +	info "fatal: $*" >&2
> 
> Shouldn't info also output to stderr?
die is calling info. So this patch is enough.

You should just send this patch to the author. I think he'll apply it instantly. I've send a small patch to him yesterday as well.

Marc Weber
martin f krafft· Nov 21, 2008, 13:56 UTC · re: Marc Weber · lore
also sprach Marc Weber <marco-oweber@gmx.de> [2008.11.21.1428 +0100]:
> > Shouldn't info also output to stderr?
> 
> die is calling info. So this patch is enough.

Sure, I was just wondering whether info() shouldn't also print to stderr. Or only die(). I think info() prints status messages, which are not standard operation and thus don't go to stdout, but go to stderr. No?

> You should just send this patch to the author. I think he'll apply
> it instantly. I've send a small patch to him yesterday as well.
Yes, but I applied that. :)
(I am Petr's apprentice, learning to help him a bit with TopGit).
-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"wovon man nicht sprechen kann, darüber muß man schweigen."
                                                       -- wittgenstein
 
spamtraps: madduck.bogus@madduck.net

← back to recent threads