# [PATCH] Retain multiple -q/-v occurrences in git pull 5 messages from 2008-11-17 to 2008-11-19. Participants: Tuncer Ayaz, Junio C Hamano, Constantine Plotnikov. Thread: https://gitlist.dev/t/16372 ## Tuncer Ayaz, 2008-11-17 22:09 Subject: [PATCH] Retain multiple -q/-v occurrences in git pull Message-ID: <1226959770-4252-1-git-send-email-tuncer.ayaz@gmail.com> URL: https://gitlist.dev/e/1226959770-4252-1-git-send-email-tuncer.ayaz%40gmail.com ``` To support counting -q/-v options in git pull retain them by concatenating. Signed-off-by: Tuncer Ayaz --- git-pull.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-pull.sh b/git-pull.sh index 8866f2a..1cac898 100755 --- a/git-pull.sh +++ b/git-pull.sh @@ -24,9 +24,9 @@ while : do case "$1" in -q|--quiet) - verbosity=-q ;; + verbosity="$verbosity -q" ;; -v|--verbose) - verbosity=-v ;; + verbosity="$verbosity -v" ;; -n|--no-stat|--no-summary) no_stat=-n ;; --stat|--summary) -- 1.6.0.2.GIT ``` ## Junio C Hamano, 2008-11-19 01:53 Subject: Re: [PATCH] Retain multiple -q/-v occurrences in git pull Message-ID: <7vd4gstr9n.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vd4gstr9n.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1226959770-4252-1-git-send-email-tuncer.ayaz@gmail.com> ``` Thanks, queued. ``` ## Constantine Plotnikov, 2008-11-19 11:46 Subject: Re: [PATCH] Retain multiple -q/-v occurrences in git pull Message-ID: <85647ef50811190346x11aea0fay3a8a7dfd8ddf6abc@mail.gmail.com> URL: https://gitlist.dev/e/85647ef50811190346x11aea0fay3a8a7dfd8ddf6abc%40mail.gmail.com In-Reply-To: <1226959770-4252-1-git-send-email-tuncer.ayaz@gmail.com> ``` On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz wrote: > To support counting -q/-v options in git pull retain > them by concatenating. > [rest of message cut] By the way, there is yet another way to invoke git fetch. It is "git remote update". Possibly it should support "-v" and "-q" options for consistency as well. Regards, Constantine ``` ## Tuncer Ayaz, 2008-11-19 22:47 Subject: Re: [PATCH] Retain multiple -q/-v occurrences in git pull Message-ID: <4ac8254d0811191447q7c9c475fka30a15c21b10524e@mail.gmail.com> URL: https://gitlist.dev/e/4ac8254d0811191447q7c9c475fka30a15c21b10524e%40mail.gmail.com In-Reply-To: <85647ef50811190346x11aea0fay3a8a7dfd8ddf6abc@mail.gmail.com> ``` On Wed, Nov 19, 2008 at 12:46 PM, Constantine Plotnikov wrote: > On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz wrote: >> To support counting -q/-v options in git pull retain >> them by concatenating. >> > [rest of message cut] > > By the way, there is yet another way to invoke git fetch. It is "git > remote update". Possibly it should support "-v" and "-q" options for > consistency as well. Yes, we could add -q to builtin-remote and also make sure that it passes the already existing -v and maybe a yet-to-be-added -q to the fetch command. I want to be first sure what the overall strategy regarding -q/-v is. Right now we have some code which uses OPT__VERBOSE/OPT__QUIET and some new code which uses the newly-added OPT__VERBOSITY. These are the options I can see: 1) Use the old and new macros and decide in each module which one to use 2) Get rid off OPT__VERBOSE and OPT__QUIET and use OPT__VERBOSITY only 3) Think about new ways to handle all of this. Possibly some new print_* macros? Any opinions? ``` ## Tuncer Ayaz, 2008-11-19 23:00 Subject: Re: [PATCH] Retain multiple -q/-v occurrences in git pull Message-ID: <4ac8254d0811191500q4e06558aj79926ab9d2401e7f@mail.gmail.com> URL: https://gitlist.dev/e/4ac8254d0811191500q4e06558aj79926ab9d2401e7f%40mail.gmail.com In-Reply-To: <4ac8254d0811191458r2a205be3w4a412553edc9b07f@mail.gmail.com> ``` [re-sent due to propagated wrong Junio address. sorry.] On Wed, Nov 19, 2008 at 12:46 PM, Constantine Plotnikov wrote: > On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz wrote: >> To support counting -q/-v options in git pull retain >> them by concatenating. >> > [rest of message cut] > > By the way, there is yet another way to invoke git fetch. It is "git > remote update". Possibly it should support "-v" and "-q" options for > consistency as well. Yes, we could add -q to builtin-remote and also make sure that it passes the already existing -v and maybe a yet-to-be-added -q to the fetch command. I want to be first sure what the overall strategy regarding -q/-v is. Right now we have some code which uses OPT__VERBOSE/OPT__QUIET and some new code which uses the newly-added OPT__VERBOSITY. These are the options I can see: 1) Use the old and new macros and decide in each module which one to use 2) Get rid off OPT__VERBOSE and OPT__QUIET and use OPT__VERBOSITY only 3) Think about new ways to handle all of this. Possibly some new print_* macros? Any opinions? ```