# [PATCH (GITK)] gitk: Make line origin search update the busy status.

2 messages from 2008-11-13 to 2008-11-13. Participants: Alexander Gavrilov, Paul Mackerras.
Thread: https://gitlist.dev/t/16319

## Alexander Gavrilov, 2008-11-13 20:43

Subject: [PATCH (GITK)] gitk: Make line origin search update the busy status.
Message-ID: <200811132343.13910.angavrilov@gmail.com>
URL: https://gitlist.dev/e/200811132343.13910.angavrilov%40gmail.com

```
Currently the 'show origin of this line' feature does
not update the status field of the gitk window, so it
is not evident that any processing is going on. It may
seem at first that clicking the item had no effect.

This commit adds calls to set and clear the busy
status with an appropriate title, similar to other
search commands.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 gitk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index e4562d7..3fb9c44 100755
--- a/gitk
+++ b/gitk
@@ -3400,6 +3400,7 @@ proc show_line_source {} {
 	error_popup [mc "Couldn't start git blame: %s" $err]
 	return
     }
+    nowbusy blaming [mc "Blaming"]
     fconfigure $f -blocking 0
     set i [reg_instance $f]
     set blamestuff($i) {}
@@ -3413,6 +3414,7 @@ proc stopblaming {} {
     if {[info exists blameinst]} {
 	stop_instance $blameinst
 	unset blameinst
+	notbusy blaming
     }
 }
 
@@ -3427,6 +3429,7 @@ proc read_line_source {fd inst} {
     }
     unset commfd($inst)
     unset blameinst
+    notbusy blaming
     fconfigure $fd -blocking 1
     if {[catch {close $fd} err]} {
 	error_popup [mc "Error running git blame: %s" $err]
-- 
1.6.0.3.15.gb8d36

```

## Paul Mackerras, 2008-11-13 22:00

Subject: Re: [PATCH (GITK)] gitk: Make line origin search update the busy status.
Message-ID: <18716.41862.32019.303080@cargo.ozlabs.ibm.com>
URL: https://gitlist.dev/e/18716.41862.32019.303080%40cargo.ozlabs.ibm.com
In-Reply-To: <200811132343.13910.angavrilov@gmail.com>

```
Alexander Gavrilov writes:

> Currently the 'show origin of this line' feature does
> not update the status field of the gitk window, so it
> is not evident that any processing is going on. It may
> seem at first that clicking the item had no effect.
> 
> This commit adds calls to set and clear the busy
> status with an appropriate title, similar to other
> search commands.

I have been meaning to do this myself.  I want to find something
better than "Blaming" to put in the status field, though, since
"blaming" is jargon in this context.  Actually, "Searching" would
probably do.

Paul.

```