# [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients 5 messages from 2008-11-12 to 2008-11-12. Participants: Michael Adam, Junio C Hamano. Thread: https://gitlist.dev/t/16289 ## Michael Adam, 2008-11-12 16:21 Subject: [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients Message-ID: URL: https://gitlist.dev/e/E1L0ITB-00Bv9t-72%40intern.SerNet.DE ``` This changes the behaviour of post-receive-email when a list of recipients (separated by commas) is specified as hooks.mailinglist. With this modification, an individual mail is sent out for each recipient entry in the list, instead of sending a single mail with all the recipients in the "To: " field. Signed-off-by: Michael Adam --- contrib/hooks/post-receive-email | 30 +++++++++++++++++------------- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 28a3c0e..5deaf28 100644 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -169,21 +169,25 @@ generate_email() describe=$rev fi - generate_email_header + # loop over the recipients to send individual mails + echo $recipients | sed -e 's/\s*,\s*/\n/' | while read recipient + do + generate_email_header - # Call the correct body generation function - fn_name=general - case "$refname_type" in - "tracking branch"|branch) - fn_name=branch - ;; - "annotated tag") - fn_name=atag - ;; - esac - generate_${change_type}_${fn_name}_email + # Call the correct body generation function + fn_name=general + case "$refname_type" in + "tracking branch"|branch) + fn_name=branch + ;; + "annotated tag") + fn_name=atag + ;; + esac + generate_${change_type}_${fn_name}_email - generate_email_footer + generate_email_footer + done } generate_email_header() -- 1.5.6 ``` ## Junio C Hamano, 2008-11-12 17:49 Subject: Re: [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients Message-ID: <7vfxlwq1gn.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vfxlwq1gn.fsf%40gitster.siamese.dyndns.org In-Reply-To: ``` Michael Adam writes: > This changes the behaviour of post-receive-email when a list of recipients > (separated by commas) is specified as hooks.mailinglist. With this modification, > an individual mail is sent out for each recipient entry in the list, instead > of sending a single mail with all the recipients in the "To: " field. Why can that be an improvement? ``` ## Michael Adam, 2008-11-12 17:58 Subject: Re: [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients Message-ID: URL: https://gitlist.dev/e/E1L0Jyh-00Bzdi-7r%40intern.SerNet.DE In-Reply-To: <7vfxlwq1gn.fsf@gitster.siamese.dyndns.org> ``` Junio C Hamano wrote: > Michael Adam writes: > > > This changes the behaviour of post-receive-email when a list of recipients > > (separated by commas) is specified as hooks.mailinglist. With this modification, > > an individual mail is sent out for each recipient entry in the list, instead > > of sending a single mail with all the recipients in the "To: " field. > > Why can that be an improvement? My use case is that I have a repository where I want to send commit messages to an "official" mailing list and to a private recipient list that might not want to be seen on the official mailing list. If this is not generally useful, I could make it optional or add s/th like a secondary mailing list argument to hooks. Cheers - Michael ``` ## Junio C Hamano, 2008-11-12 18:18 Subject: Re: [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients Message-ID: <7v3ahwq043.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7v3ahwq043.fsf%40gitster.siamese.dyndns.org In-Reply-To: ``` Michael Adam writes: > Junio C Hamano wrote: >> Michael Adam writes: >> >> > This changes the behaviour of post-receive-email when a list of recipients >> > (separated by commas) is specified as hooks.mailinglist. With this modification, >> > an individual mail is sent out for each recipient entry in the list, instead >> > of sending a single mail with all the recipients in the "To: " field. >> >> Why can that be an improvement? > > My use case is that I have a repository where I want to send > commit messages to an "official" mailing list and to a private > recipient list that might not want to be seen on the official > mailing list. Ah. What you want is a capability to add Bcc:, not a misfeature to run the log formatter repeatedly wasting cycles only to generate the same message contents. ``` ## Michael Adam, 2008-11-12 22:21 Subject: Re: [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients Message-ID: URL: https://gitlist.dev/e/E1L0O5U-00CBIw-3Y%40intern.SerNet.DE In-Reply-To: <7v3ahwq043.fsf@gitster.siamese.dyndns.org> ``` Junio C Hamano wrote: > Michael Adam writes: > > > Junio C Hamano wrote: > >> Michael Adam writes: > >> > >> > This changes the behaviour of post-receive-email when a list of recipients > >> > (separated by commas) is specified as hooks.mailinglist. With this modification, > >> > an individual mail is sent out for each recipient entry in the list, instead > >> > of sending a single mail with all the recipients in the "To: " field. > >> > >> Why can that be an improvement? > > > > My use case is that I have a repository where I want to send > > commit messages to an "official" mailing list and to a private > > recipient list that might not want to be seen on the official > > mailing list. > > Ah. What you want is a capability to add Bcc:, not a misfeature to run > the log formatter repeatedly wasting cycles only to generate the same > message contents. The intent was to send out the mail not to a (large) list of individual recipients but to some (few) mailing lists separately. A Bcc would be a partial solution. I also thought about that, but I did not like it since it might make those recipients in the bcc field feel strange because they seem to be getting mail from a list they might not be subscribed to. Group-replying to such mails may also cause confusion... Of course my patch could be optimized for not wasting cycles by only running generate_email_header() multiple times and caching the results of the log formatter and generate_email_footer(). But I understand that my problem is a very specific one and that generally no benefit but only disadvantage is seen in the modification I suggested. -- Sorry for the noise. :-) Cheers - Michael ```