[PATCH] Tell users that git protocol is not for pushing

Nathan W. Panike· Nov 11, 2008, 05:06 UTC · lore

When one attempts to push to a git-protocol repository, one gets the line:

fatal: The remote end hung up unexpectedly

This seems a bit obscure to me.  It is better to inform the user that git://
does not allow pushing.
---
 transport.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Show changes to transport.c +3 −1

diff --git a/transport.c b/transport.c
index 56831c5..2c1577e 100644
--- a/transport.c
+++ b/transport.c
@@ -684,7 +684,9 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const
 	args.use_thin_pack = data->thin;
 	args.verbose = !!(flags & TRANSPORT_PUSH_VERBOSE);
 	args.dry_run = !!(flags & TRANSPORT_PUSH_DRY_RUN);
-
+	if(strncmp(transport->url,"git",3)==0){
+		fprintf(stderr,"git protocol does not support push.\n");
+	}
 	return send_pack(&args, transport->url, transport->remote, refspec_nr, refspec);
 }

-- 
1.6.0.4

Alex Riesen· Nov 11, 2008, 07:24 UTC · re: Nathan W. Panike · lore

Re: [PATCH] Tell users that git protocol is not for pushing

Nathan W. Panike, Tue, Nov 11, 2008 06:06:16 +0100:

Show 7 quoted lines

> When one attempts to push to a git-protocol repository, one gets the
> line:
> 
> fatal: The remote end hung up unexpectedly
> 
> This seems a bit obscure to me.  It is better to inform the user that git://
> does not allow pushing.

But it does. See git daemon --help, look for receive-pack.

patchTell users that git protocol is not for pushing