threads / patch / 16252

patchvery small cleanup: #undef a macro that isn't used anywhere else

Subject: [PATCH] very small cleanup: #undef a macro that isn't used anywhere else

## tl;dr

3 messages between Nov 10, 2008 and Nov 10, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Francis Galiegue· Nov 10, 2008, 18:28 UTC · lore

In xdiff-interface.c, the FIRST_FEW_BYTES macro is defined, is never used
anwhere else, so we might as well undefine it after we're done with it.
---
 xdiff-interface.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to xdiff-interface.c +1 −1

diff --git a/xdiff-interface.c b/xdiff-interface.c
index e8ef46d..2cf30cd 100644
--- a/xdiff-interface.c
+++ b/xdiff-interface.c
@@ -226,6 +226,7 @@ int buffer_is_binary(const char *ptr, unsigned long size)
                size = FIRST_FEW_BYTES;
        return !!memchr(ptr, 0, size);
 }
+#undef FIRST_FEW_BYTES

 struct ff_regs {
        int nr;
--
1.6.0.3

-- 
fge

Johannes Schindelin· Nov 10, 2008, 19:09 UTC · re: Francis Galiegue · lore

Re: [PATCH] very small cleanup: #undef a macro that isn't used anywhere else

Hi,

On Mon, 10 Nov 2008, Francis Galiegue wrote:

> In xdiff-interface.c, the FIRST_FEW_BYTES macro is defined, is never 
> used anwhere else, so we might as well undefine it after we're done with 
> it.

Would not the consequence be that we end up with a ton of #undefines all over the place, reducing readability incredibly?

Ciao, Dscho

Francis Galiegue· Nov 10, 2008, 19:09 UTC · re: Johannes Schindelin · lore

Re: [PATCH] very small cleanup: #undef a macro that isn't used anywhere else

Le Monday 10 November 2008 20:09:21 Johannes Schindelin, vous avez écrit :

Show 10 quoted lines

> Hi,
>
> On Mon, 10 Nov 2008, Francis Galiegue wrote:
> > In xdiff-interface.c, the FIRST_FEW_BYTES macro is defined, is never
> > used anwhere else, so we might as well undefine it after we're done with
> > it.
>
> Would not the consequence be that we end up with a ton of #undefines all
> over the place, reducing readability incredibly?
>

Hmwell, this is a twofold argument, I guess...

* for: the macro is defined, not undefined: it means that potentially, it can 
be used somewhere else in the file; but it isn't (in this case);
* against: macros defined in a C file only ever have scope in said file 
(unless so mischievous Makefile cats two C files together before compile and 
file order is important -- but git doesn't do that), so why #undefine 
anything?

Personally, I'm with the first argument. YMMV, of course.

-- 
fge