threads / patch / 16241

patchgit-gui: Request blame metadata in utf-8.

Subject: [PATCH (GIT-GUI)] git-gui: Request blame metadata in utf-8.

## tl;dr

2 messages between Nov 9, 2008 and Nov 11, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Alexander Gavrilov· Nov 9, 2008, 15:53 UTC · lore

The blame builtin now supports automatic conversion of metadata encoding. By default it is converted to the character set specified by i18n.logoutputencoding.

Since gui blame expects the data in utf-8, it is necessary to specify the desired encoding directly. An old version of the blame command will simply ignore the option.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 lib/blame.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to lib/blame.tcl +1 −1
diff --git a/lib/blame.tcl b/lib/blame.tcl
index 8d60f12..4875804 100644
--- a/lib/blame.tcl
+++ b/lib/blame.tcl
@@ -559,7 +559,7 @@ method _read_file {fd jump} {
 } ifdeleted { catch {close $fd} }
 
 method _exec_blame {cur_w cur_d options cur_s} {
-	lappend options --incremental
+	lappend options --incremental --encoding=utf-8
 	if {$commit eq {}} {
 		lappend options --contents $path
 	} else {
-- 
1.6.0.3.15.gb8d36
Shawn O. Pearce· Nov 11, 2008, 17:35 UTC · re: Alexander Gavrilov · lore

Re: [PATCH (GIT-GUI)] git-gui: Request blame metadata in utf-8.

Alexander Gavrilov <angavrilov@gmail.com> wrote:
Show 8 quoted lines
> The blame builtin now supports automatic conversion of
> metadata encoding. By default it is converted to the
> character set specified by i18n.logoutputencoding.
> 
> Since gui blame expects the data in utf-8, it is
> necessary to specify the desired encoding directly.
> An old version of the blame command will simply
> ignore the option.
Thanks; all 3 applied.
 
-- 
Shawn.

← back to recent threads