threads / patch / 16120

patchadd instructions on how to send patches to the mailing list with Gmail

Subject: [PATCH] add instructions on how to send patches to the mailing list with Gmail

## tl;dr

5 messages between Nov 1, 2008 and Nov 2, 2008. Diffs are folded; open one to read it.

replies: 4people: 4as markdown or json

Tom Preston-Werner· Nov 1, 2008, 07:28 UTC · lore

Gmail is one of the most popular email providers in the world. Now that Gmail supports IMAP, sending properly formatted patches via `git imap-send` is trivial. This section in SubmittingPatches explains how to do so.

Signed-off-by: Tom Preston-Werner <tom@github.com>
---
 Documentation/SubmittingPatches |   27 +++++++++++++++++++++++++++
 1 files changed, 27 insertions(+), 0 deletions(-)
Show changes to Documentation/SubmittingPatches +27 −0
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index a1e9100..f0295c6 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -456,3 +456,30 @@ This should help you to submit patches inline using KMail.

 5) Back in the compose window: add whatever other text you wish to the
 message, complete the addressing and subject fields, and press send.
+
+
+Gmail
+-----
+
+Submitting properly formatted patches via Gmail is simple now that
+IMAP support is available. First, edit your ~/.gitconfig to specify your
+account settings:
+
+[imap]
+	folder = "[Gmail]/Drafts"
+	host = imaps://imap.gmail.com
+	user = user@gmail.com
+	pass = p4ssw0rd
+	port = 993
+	sslverify = false
+
+Next, ensure that your Gmail settings are correct. In "Settings" the
+"Use Unicode (UTF-8) encoding for outgoing messages" should be checked.
+
+Once your commits are ready to send to the mailing list, run the following
+command to send the patch emails to your Gmail Drafts folder.
+
+	$ git format-patch -M --stdout origin/master | git imap-send
+
+Go to your Gmail account, open the Drafts folder, find the patch email, fill
+in the To: and CC: fields and send away!

-- 
1.6.0.2
Santi Béjar· Nov 1, 2008, 10:00 UTC · re: Tom Preston-Werner · lore

Re: [PATCH] add instructions on how to send patches to the mailing list with Gmail

On Sat, Nov 1, 2008 at 8:28 AM, Tom Preston-Werner <tom@github.com> wrote:
Show 33 quoted lines
> Gmail is one of the most popular email providers in the world. Now that Gmail
> supports IMAP, sending properly formatted patches via `git imap-send` is
> trivial. This section in SubmittingPatches explains how to do so.
>
> Signed-off-by: Tom Preston-Werner <tom@github.com>
> ---
>  Documentation/SubmittingPatches |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index a1e9100..f0295c6 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -456,3 +456,30 @@ This should help you to submit patches inline using KMail.
>
>  5) Back in the compose window: add whatever other text you wish to the
>  message, complete the addressing and subject fields, and press send.
> +
> +
> +Gmail
> +-----
> +
> +Submitting properly formatted patches via Gmail is simple now that
> +IMAP support is available. First, edit your ~/.gitconfig to specify your
> +account settings:
> +
> +[imap]
> +       folder = "[Gmail]/Drafts"
> +       host = imaps://imap.gmail.com
> +       user = user@gmail.com
> +       pass = p4ssw0rd
> +       port = 993
> +       sslverify = false
Warning: It is not secure.
Show 11 quoted lines
> +
> +Next, ensure that your Gmail settings are correct. In "Settings" the
> +"Use Unicode (UTF-8) encoding for outgoing messages" should be checked.
> +
> +Once your commits are ready to send to the mailing list, run the following
> +command to send the patch emails to your Gmail Drafts folder.
> +
> +       $ git format-patch -M --stdout origin/master | git imap-send
> +
> +Go to your Gmail account, open the Drafts folder, find the patch email, fill
> +in the To: and CC: fields and send away!
Are you sure the mail does not get whitespace damaged?
Santi
Tom Preston-Werner· Nov 1, 2008, 20:40 UTC · re: Santi Béjar · lore

Re: [PATCH] add instructions on how to send patches to the mailing list with Gmail

On Sat, Nov 1, 2008 at 3:00 AM, Santi Béjar <santi@agolina.net> wrote:
Show 36 quoted lines
> On Sat, Nov 1, 2008 at 8:28 AM, Tom Preston-Werner <tom@github.com> wrote:
>> Gmail is one of the most popular email providers in the world. Now that Gmail
>> supports IMAP, sending properly formatted patches via `git imap-send` is
>> trivial. This section in SubmittingPatches explains how to do so.
>>
>> Signed-off-by: Tom Preston-Werner <tom@github.com>
>> ---
>>  Documentation/SubmittingPatches |   27 +++++++++++++++++++++++++++
>>  1 files changed, 27 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
>> index a1e9100..f0295c6 100644
>> --- a/Documentation/SubmittingPatches
>> +++ b/Documentation/SubmittingPatches
>> @@ -456,3 +456,30 @@ This should help you to submit patches inline using KMail.
>>
>>  5) Back in the compose window: add whatever other text you wish to the
>>  message, complete the addressing and subject fields, and press send.
>> +
>> +
>> +Gmail
>> +-----
>> +
>> +Submitting properly formatted patches via Gmail is simple now that
>> +IMAP support is available. First, edit your ~/.gitconfig to specify your
>> +account settings:
>> +
>> +[imap]
>> +       folder = "[Gmail]/Drafts"
>> +       host = imaps://imap.gmail.com
>> +       user = user@gmail.com
>> +       pass = p4ssw0rd
>> +       port = 993
>> +       sslverify = false
>
> Warning: It is not secure.

It is true that the certificate is not verified, but since the patches are destined for a public mailing list, this does not represent a large problem.

Show 13 quoted lines
>> +
>> +Next, ensure that your Gmail settings are correct. In "Settings" the
>> +"Use Unicode (UTF-8) encoding for outgoing messages" should be checked.
>> +
>> +Once your commits are ready to send to the mailing list, run the following
>> +command to send the patch emails to your Gmail Drafts folder.
>> +
>> +       $ git format-patch -M --stdout origin/master | git imap-send
>> +
>> +Go to your Gmail account, open the Drafts folder, find the patch email, fill
>> +in the To: and CC: fields and send away!
>
> Are you sure the mail does not get whitespace damaged?

Yes, I have sent patches using exactly this method. Here is an example of one I sent today: http://article.gmane.org/gmane.comp.version-control.git/99759. Tabs are preserved and lines are not wrapped improperly.

Tom
Pierre Habouzit· Nov 2, 2008, 09:10 UTC · re: Tom Preston-Werner · lore

Re: [PATCH] add instructions on how to send patches to the mailing list with Gmail

On Sat, Nov 01, 2008 at 08:40:27PM +0000, Tom Preston-Werner wrote:
Show 41 quoted lines
> On Sat, Nov 1, 2008 at 3:00 AM, Santi Béjar <santi@agolina.net> wrote:
> > On Sat, Nov 1, 2008 at 8:28 AM, Tom Preston-Werner <tom@github.com> wrote:
> >> Gmail is one of the most popular email providers in the world. Now that Gmail
> >> supports IMAP, sending properly formatted patches via `git imap-send` is
> >> trivial. This section in SubmittingPatches explains how to do so.
> >>
> >> Signed-off-by: Tom Preston-Werner <tom@github.com>
> >> ---
> >>  Documentation/SubmittingPatches |   27 +++++++++++++++++++++++++++
> >>  1 files changed, 27 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> >> index a1e9100..f0295c6 100644
> >> --- a/Documentation/SubmittingPatches
> >> +++ b/Documentation/SubmittingPatches
> >> @@ -456,3 +456,30 @@ This should help you to submit patches inline using KMail.
> >>
> >>  5) Back in the compose window: add whatever other text you wish to the
> >>  message, complete the addressing and subject fields, and press send.
> >> +
> >> +
> >> +Gmail
> >> +-----
> >> +
> >> +Submitting properly formatted patches via Gmail is simple now that
> >> +IMAP support is available. First, edit your ~/.gitconfig to specify your
> >> +account settings:
> >> +
> >> +[imap]
> >> +       folder = "[Gmail]/Drafts"
> >> +       host = imaps://imap.gmail.com
> >> +       user = user@gmail.com
> >> +       pass = p4ssw0rd
> >> +       port = 993
> >> +       sslverify = false
> >
> > Warning: It is not secure.
> 
> It is true that the certificate is not verified, but since the patches
> are destined for a public mailing list, this does not represent a
> large problem.

What he means is that the password is cleartext ;) (I think)

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Fredrik Skolmli· Nov 2, 2008, 15:01 UTC · re: Pierre Habouzit · lore

Re: [PATCH] add instructions on how to send patches to the mailing list with Gmail

On Sun, Nov 02, 2008 at 10:10:06AM +0100, Pierre Habouzit wrote:
Show 8 quoted lines
> > > Warning: It is not secure.
> > 
> > It is true that the certificate is not verified, but since the patches
> > are destined for a public mailing list, this does not represent a
> > large problem.
> 
> What he means is that the password is cleartext ;)
> (I think)

The way I read and understand it, the issues arises if a MITM-attack takes place. If the client doesn't verify the certificate, an attacker can easily get the username and password.

So unless someone creates a separate gmail-account for submitting patches, one should really trust the connection (ie not a public wlan), or verify the certificate before transmitting the password.

-- 
Kind regards,
Fredrik Skolmli

← back to recent threads