threads / discuss / 15914

StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

Subject: StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

## tl;dr

3 messages between Oct 15, 2008 and Oct 19, 2008.

replies: 2people: 2as markdown or json

Andrey Borzenkov· Oct 15, 2008, 16:25 UTC · lore

Hi,

Funny problem. I have following export template:

Subject: [PATCH] %(shortdescr)s
From: %(authname)s %(authemail)s

%(longdescr)s
Signed-off-by: %(authname)s %(authemail)s

---

%(diffstat)s

So after "stg new", edit, "stg refres" (and any number of "stg refresh"es) it exports OK. But once I did "stg edit patch", all subsequent "stg export patch" will give (assuming author is me@foo.net):

From: My Name < me@foo.net>
...
Signed-off-by: My Name < me@foo.net>

Notice extra space between "<" and e-mail.

TIA

-andrey

Catalin Marinas· Oct 18, 2008, 08:48 UTC · re: Andrey Borzenkov · lore

Re: StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

2008/10/15 Andrey Borzenkov <arvidjaar@mail.ru>:

Show 7 quoted lines

> Funny problem. I have following export template:
>
> Subject: [PATCH] %(shortdescr)s
> From: %(authname)s %(authemail)s
>
> %(longdescr)s
> Signed-off-by: %(authname)s %(authemail)s

The default templates contain "%(authname)s <%(authemail)s>", i.e. with the angle brackets arount authemail and I've never seen this problem. Does it work if you change them (or use the default templates)?

-- 
Catalin

Andrey Borzenkov· Oct 19, 2008, 08:09 UTC · re: Catalin Marinas · lore

Re: StGIT 0.14.3: extra space is added before e-mail on export after "stg edit"

On Saturday 18 October 2008, Catalin Marinas wrote:

Show 14 quoted lines

> 2008/10/15 Andrey Borzenkov <arvidjaar@mail.ru>:
> > Funny problem. I have following export template:
> >
> > Subject: [PATCH] %(shortdescr)s
> > From: %(authname)s %(authemail)s
> >
> > %(longdescr)s
> > Signed-off-by: %(authname)s %(authemail)s
> 
> The default templates contain "%(authname)s <%(authemail)s>", i.e.
> with the angle brackets arount authemail and I've never seen this
> problem. Does it work if you change them (or use the default
> templates)?
>

Well, my GIT_AUTHOR_EMAIL was with angle brackets. I do not remember, why (apparently I had some issues in the past). I stripped brackets and changed template, now it seems to work. I was never sure what exactly e-mail should like like.

Thank you!