# [PATCH] Git.pm: release hash and blob handles 2 messages from 2008-10-11 to 2008-10-11. Participants: Ray Chuan, Petr Baudis. Thread: https://gitlist.dev/t/15864 ## Ray Chuan, 2008-10-11 19:29 Subject: [PATCH] Git.pm: release hash and blob handles Message-ID: URL: https://gitlist.dev/e/be6fef0d0810111229u60c28671w1afd952200c6fa23%40mail.gmail.com ``` the methods * hash_and_insert_object * cat_blob use bidirectional pipes to pull/push data from the various git utilities, but they don't close them after this is complete. this denies Git's subsequent attempts to use these resources, leading to failure. a simple, reproducible test case can be seen at http://rctay.spaces.live.com/blog/cns!59D3BFCD027B09E5!792.entry. Signed-off-by: Tay Ray Chuan gmail.com> --- perl/Git.pm | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/perl/Git.pm b/perl/Git.pm index 6aab712..7e17f38 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -821,6 +821,7 @@ sub hash_and_insert_object { throw Error::Simple("in pipe went bad"); } + $self->_close_hash_and_insert_object(); return $hash; } @@ -910,6 +911,7 @@ sub cat_blob { throw Error::Simple("couldn't write to passed in filehandle"); } + $self->_close_cat_blob(); return $size; } -- 1.6.0.2 ``` ## Petr Baudis, 2008-10-11 21:23 Subject: Re: [PATCH] Git.pm: release hash and blob handles Message-ID: <20081011212322.GU10544@machine.or.cz> URL: https://gitlist.dev/e/20081011212322.GU10544%40machine.or.cz In-Reply-To: ``` On Sun, Oct 12, 2008 at 03:29:28AM +0800, Ray Chuan wrote: > the methods > > * hash_and_insert_object > * cat_blob > > use bidirectional pipes to pull/push data from the various git > utilities, but they don't close them after this is complete. this > denies Git's subsequent attempts to use these resources, leading to > failure. > > a simple, reproducible test case can be seen at > http://rctay.spaces.live.com/blog/cns!59D3BFCD027B09E5!792.entry. Hmm, I don't understand why git-svn does not work for you, but this patch is not correct. The whole point of the infrastructure is to leave the pipes open so that subsequent calls _reuse_ these pipes. This leads to substantial speedup as you do not need to re-fork git all the time. -- Petr "Pasky" Baudis People who take cold baths never have rheumatism, but they have cold baths. ```