# [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings 4 messages from 2008-10-02 to 2008-10-02. Participants: David Soria Parra, Jeff King, Brandon Casey. Thread: https://gitlist.dev/t/15741 ## David Soria Parra, 2008-10-02 00:08 Subject: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings Message-ID: <1222906127-16900-1-git-send-email-sn_@gmx.net> URL: https://gitlist.dev/e/1222906127-16900-1-git-send-email-sn_%40gmx.net ``` From: David Soria Parra Solaris systems use the old styled iconv(3) call and therefore the OLD_ICONV variable should be set. Otherwise we get annoying compile warnings. Signed-off-by: David Soria Parra --- Makefile | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 7db2ccc..3abbb4e 100644 --- a/Makefile +++ b/Makefile @@ -649,6 +649,7 @@ ifeq ($(uname_S),SunOS) NO_MEMMEM = YesPlease NO_HSTRERROR = YesPlease NO_MKDTEMP = YesPlease + OLD_ICONV = UnfortunatelyYes ifeq ($(uname_R),5.8) NEEDS_LIBICONV = YesPlease NO_UNSETENV = YesPlease -- 1.6.0.2.569.g798a2a ``` ## Jeff King, 2008-10-02 01:08 Subject: Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings Message-ID: <20081002010816.GA27415@coredump.intra.peff.net> URL: https://gitlist.dev/e/20081002010816.GA27415%40coredump.intra.peff.net In-Reply-To: <1222906127-16900-1-git-send-email-sn_@gmx.net> ``` On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote: > Solaris systems use the old styled iconv(3) call and therefore > the OLD_ICONV variable should be set. Otherwise we get annoying compile > warnings. Acked-by: Jeff King I set OLD_ICONV on my Solaris build. Do you also unset NEEDS_LIBICONV (and which version of Solaris are you running)? Our Makefile sets it to "yes" for Solaris 8, but my build box requires that it be unset. I'm not sure if my setup is somehow deficient, or if it is only other versions that need it. -Peff ``` ## David Soria Parra, 2008-10-02 10:09 Subject: Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings Message-ID: <48E49DD6.7000708@gmx.net> URL: https://gitlist.dev/e/48E49DD6.7000708%40gmx.net In-Reply-To: <20081002010816.GA27415@coredump.intra.peff.net> ``` Jeff King schrieb: > Do you also unset NEEDS_LIBICONV (and which version of Solaris are you > running)? Our Makefile sets it to "yes" for Solaris 8, but my build box > requires that it be unset. I'm not sure if my setup is somehow > deficient, or if it is only other versions that need it. I'm using OpenSolaris which is identified as SunOS 5.11. Therefore the Makefile doesn't set NEEDS_LIBICONV. I'm not sure if it's needed on Solaris 8 or not, but it's not needed on OpenSolaris. David ``` ## Brandon Casey, 2008-10-02 15:25 Subject: Re: [PATCH] Solaris: Use OLD_ICONV to avoid compile warnings Message-ID: <5A1KxlhmUIHe8iXPxnXYuNXsq0Yjlbwkz2eBin3z7ELuL9nK-4tSpw@cipher.nrlssc.navy.mil> URL: https://gitlist.dev/e/5A1KxlhmUIHe8iXPxnXYuNXsq0Yjlbwkz2eBin3z7ELuL9nK-4tSpw%40cipher.nrlssc.navy.mil In-Reply-To: <20081002010816.GA27415@coredump.intra.peff.net> ``` Jeff King wrote: > On Thu, Oct 02, 2008 at 02:08:47AM +0200, David Soria Parra wrote: > >> Solaris systems use the old styled iconv(3) call and therefore >> the OLD_ICONV variable should be set. Otherwise we get annoying compile >> warnings. > > Acked-by: Jeff King > > I set OLD_ICONV on my Solaris build. Ditto here on 7. > > Do you also unset NEEDS_LIBICONV (and which version of Solaris are you > running)? I do not set NEEDS_LIBICONV. -brandon ```