threads / patch / 15716

patchgit-gui: Remove space from the end of aspell's reply before processing

Subject: [PATCH] git-gui: Remove space from the end of aspell's reply before processing

## tl;dr

One message between Sep 30, 2008 and Sep 30, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Johannes Sixt· Sep 30, 2008, 06:39 UTC · lore
From: Johannes Sixt <johannes.sixt@telecom.at>

When git gui processes a reply from aspell it explicitly ignores an empty line. The Windows version of aspell, however, terminates lines with CRLF, but TCL's 'gets' does not remove CR, hence, a "visibly" empty line was not actually recognized as empty. With this change we explicitly trim off whitespace before the line is further processed.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
 There's probably a better solution by having TCL do the translation of
 line endings, but I don't know how to do that.
 -- Hannes
 lib/spellcheck.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to lib/spellcheck.tcl +1 −0
diff --git a/lib/spellcheck.tcl b/lib/spellcheck.tcl
index a479b2f..e612030 100644
--- a/lib/spellcheck.tcl
+++ b/lib/spellcheck.tcl
@@ -314,6 +314,7 @@ method _run {} {
 method _read {} {
 	while {[gets $s_fd line] >= 0} {
 		set lineno [lindex $s_pending 0 0]
+		set line [string trim $line]

 		if {$s_clear} {
 			$w_text tag remove misspelled "$lineno.0" "$lineno.end"
-- 
1.6.0.2.1262.ge466e

← back to recent threads