threads / patch / 15702

patchgitweb: remove PATH_INFO from $my_url and $my_uri

Subject: [PATCH] gitweb: remove PATH_INFO from $my_url and $my_uri

## tl;dr

3 messages between Sep 29, 2008 and Oct 2, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Giuseppe Bilotta· Sep 29, 2008, 13:07 UTC · lore

This patch fixes PATH_INFO handling by removing the relevant part from $my_url and $my_uri, thus making it unnecessary to specify them by hand in the gitweb configuration.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 gitweb/gitweb.perl |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
Show changes to gitweb/gitweb.perl +7 −0
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index da474d0..ffe3dbf 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -27,6 +27,13 @@ our $version = "++GIT_VERSION++";
 our $my_url = $cgi->url();
 our $my_uri = $cgi->url(-absolute => 1);
 
+# if we're called with PATH_INFO, we have to strip that
+# from the URL to find our real URL
+if (my $path_info = $ENV{"PATH_INFO"}) {
+	$my_url =~ s,\Q$path_info\E$,,;
+	$my_uri =~ s,\Q$path_info\E$,,;
+}
+
 # core git executable to use
 # this can just be "git" if your webserver has a sensible PATH
 our $GIT = "++GIT_BINDIR++/git";
-- 
1.5.6.5
Jakub Narebski· Sep 29, 2008, 13:39 UTC · re: Giuseppe Bilotta · lore

Re: [PATCH] gitweb: remove PATH_INFO from $my_url and $my_uri

Giuseppe Bilotta wrote:
Show 5 quoted lines
> This patch fixes PATH_INFO handling by removing the relevant part from
> $my_url and $my_uri, thus making it unnecessary to specify them by hand
> in the gitweb configuration.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
-- 
Jakub Narebski
Poland
Petr Baudis· Oct 2, 2008, 14:22 UTC · re: Giuseppe Bilotta · lore

Re: [PATCH] gitweb: remove PATH_INFO from $my_url and $my_uri

On Mon, Sep 29, 2008 at 03:07:42PM +0200, Giuseppe Bilotta wrote:
Show 5 quoted lines
> This patch fixes PATH_INFO handling by removing the relevant part from
> $my_url and $my_uri, thus making it unnecessary to specify them by hand
> in the gitweb configuration.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Petr Baudis <pasky@suse.cz>

← back to recent threads