threads / patch / 15686

patch, 4 partsmingw: remove use of _getdrive() from lstat/fstat

Subject: [PATCH 1/4] mingw: remove use of _getdrive() from lstat/fstat

## tl;dr

2 messages between Sep 27, 2008 and Sep 27, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Dmitry Potapov· Sep 27, 2008, 08:39 UTC · lore

The field device is not used by Git, and putting the number of the current device is meaningless anyway.

Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
---
 compat/mingw.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Show changes to compat/mingw.c +2 −3
diff --git a/compat/mingw.c b/compat/mingw.c
index ccfa2a0..a2b8cd7 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -31,7 +31,6 @@ static inline time_t filetime_to_time_t(const FILETIME *ft)
 	return (time_t)winTime;
 }
 
-extern int _getdrive( void );
 /* We keep the do_lstat code in a separate function to avoid recursion.
  * When a path ends with a slash, the stat will fail with ENOENT. In
  * this case, we strip the trailing slashes and stat again.
@@ -55,7 +54,7 @@ static int do_lstat(const char *file_name, struct stat *buf)
 		buf->st_nlink = 1;
 		buf->st_mode = fMode;
 		buf->st_size = fdata.nFileSizeLow; /* Can't use nFileSizeHigh, since it's not a stat64 */
-		buf->st_dev = buf->st_rdev = (_getdrive() - 1);
+		buf->st_dev = buf->st_rdev = 0; /* not used by Git */
 		buf->st_atime = filetime_to_time_t(&(fdata.ftLastAccessTime));
 		buf->st_mtime = filetime_to_time_t(&(fdata.ftLastWriteTime));
 		buf->st_ctime = filetime_to_time_t(&(fdata.ftCreationTime));
@@ -145,7 +144,7 @@ int mingw_fstat(int fd, struct stat *buf)
 		buf->st_nlink = 1;
 		buf->st_mode = fMode;
 		buf->st_size = fdata.nFileSizeLow; /* Can't use nFileSizeHigh, since it's not a stat64 */
-		buf->st_dev = buf->st_rdev = (_getdrive() - 1);
+		buf->st_dev = buf->st_rdev = 0; /* not used by Git */
 		buf->st_atime = filetime_to_time_t(&(fdata.ftLastAccessTime));
 		buf->st_mtime = filetime_to_time_t(&(fdata.ftLastWriteTime));
 		buf->st_ctime = filetime_to_time_t(&(fdata.ftCreationTime));
-- 
1.6.0.2.237.g0297e5
Johannes Sixt· Sep 27, 2008, 19:38 UTC · re: Dmitry Potapov · lore

Re: [PATCH 1/4] mingw: remove use of _getdrive() from lstat/fstat

On Samstag, 27. September 2008, Dmitry Potapov wrote:
> The field device is not used by Git, and putting the number of the
> current device is meaningless anyway.
Acked-by: Johannes Sixt <johannes.sixt@telecom.at>
-- Hannes

← back to recent threads