Re: git-stash.sh: don't default to refs/stash if invalid ref supplied

Brandon Casey· Sep 26, 2008, 15:19 UTC · lore

git-stash.sh: don't default to refs/stash if invalid ref supplied

   commit da65e7c133cd316c9076fbb6b0aeee7bc42a6db8
   Author: Brandon Casey <casey@nrlssc.navy.mil>
   Date:   Tue Sep 23 18:57:09 2008 -0500

       git-stash.sh: don't default to refs/stash if invalid ref supplied
    
       <snip>
    
       e.g. 'git stash apply stash@{1}' would fall back to
            'git stash apply stash@{0}'

heh, you fixed my spelling "mistake" :), but it wasn't a mistake. Originally I had:

    e.g. 'git stash apply stahs@{1}' would fall back to
         'git stash apply stash@{0}'

intending to show that a simple spelling mistake could cause the wrong thing to be done. The example in the commit message could actually still happen if there was only a single stash entry. I guess I should have used 'foobar@{1}'. :)

-brandon

Shawn O. Pearce· Sep 26, 2008, 15:25 UTC · re: Brandon Casey · lore

Brandon Casey <casey@nrlssc.navy.mil> wrote:

Show 13 quoted lines

>    commit da65e7c133cd316c9076fbb6b0aeee7bc42a6db8
>    Author: Brandon Casey <casey@nrlssc.navy.mil>
>    Date:   Tue Sep 23 18:57:09 2008 -0500
> 
>        git-stash.sh: don't default to refs/stash if invalid ref supplied
>     
>        <snip>
>     
>        e.g. 'git stash apply stash@{1}' would fall back to
>             'git stash apply stash@{0}'
> 
> heh, you fixed my spelling "mistake" :), but it wasn't a mistake. Originally
> I had:

Heh.  I geuss my spleling meter was working overtime yesterday?  ;-)

Show 6 quoted lines

>     e.g. 'git stash apply stahs@{1}' would fall back to
>          'git stash apply stash@{0}'
> 
> intending to show that a simple spelling mistake could cause the wrong thing
> to be done. The example in the commit message could actually still happen if
> there was only a single stash entry. I guess I should have used 'foobar@{1}'. :)

Yea, reading it now I see why you had the typo in the message. But yesterday it just looked like a typo to me. Dammit. That's the last time I cleanup a typo before applying a patch!

;-)

-- 
Shawn.