Re: please consider remove those tags named master, which is ambigous with master branch

rae l· Sep 23, 2008, 14:46 UTC · lore

To Smurf and Andrew:
  Did you notice that there's a tag named "master" in the smurf
mm-trees.git repo,
this would confuse the git and the users, please consider remove the
"master" tag, OK?

---------- Forwarded message ----------
From: rae l <crquan@gmail.com>
Date: Mon, Sep 1, 2008 at 12:48 AM
Subject: please consider remove those tags named master, which is
ambigous with master branch
To: Matthias Urlichs <smurf@smurf.noris.de>

please consider remove those tags named master, which is ambigous with master branch

http://git.kernel.org/?p=linux/kernel/git/smurf/linux-trees.git;a=tags

--

To Git developers:
  I found that different git subcommand have inconsitent processing
about ambiguous refname,

git show will take "master" tag first, while git tag -v will take "master" branch first,

So what's your suggestion to fix this? Just simple remove ambiguous refnames?

Or we can add a feature to allow same refname in different namespaces (tags and branches)? Such as "-b" to refer a branch while "-t" to refer a tag name? Else how to distinguish them?

gektop@tux ~/sforge/linux-2.6 0 $ PAGER= git show master
warning: refname 'master' is ambiguous.
commit 05230bd16821e2ec80321d72e97e7a2b1a07c6f2
Author:     Adrian Bunk <bunk@stusta.de>
AuthorDate: Sat Jul 30 00:45:08 2005 +0000
Commit:     Matthias Urlichs <smurf@hera.kernel.org>
CommitDate: Mon Aug 1 05:16:36 2005 -0700

    sound-oss-sequencer_syms-unexport-reprogram_timer

    This patch remoes an unneeded EXPORT_SYMBOL.

    Signed-off-by: Andrew Morton <akpm@osdl.org>

diff --git a/sound/oss/sequencer_syms.c b/sound/oss/sequencer_syms.c
index 45edfd7..5d00879 100644
--- a/sound/oss/sequencer_syms.c
+++ b/sound/oss/sequencer_syms.c
@@ -19,7 +19,6 @@ EXPORT_SYMBOL(sequencer_timer);
 EXPORT_SYMBOL(sound_timer_init);
 EXPORT_SYMBOL(sound_timer_interrupt);
 EXPORT_SYMBOL(sound_timer_syncinterval);
-EXPORT_SYMBOL(reprogram_timer);

 /* Tuning */

gektop@tux ~/sforge/linux-2.6 0 $ git tag -v master
error: 05230bd16821e2ec80321d72e97e7a2b1a07c6f2: cannot verify a
non-tag object of type commit.
error: could not verify the tag 'master'


--
Denis Cheng Renquan

Alex Riesen· Sep 24, 2008, 15:44 UTC · re: rae l · lore

2008/9/23 rae l <crquan@gmail.com>:

Show 8 quoted lines

> To Git developers:
>  I found that different git subcommand have inconsitent processing
> about ambiguous refname,
>
> git show will take "master" tag first,
> while git tag -v will take "master" branch first,
>
> So what's your suggestion to fix this? Just simple remove ambiguous refnames?

You can use "refs/tags/master" and "refs/heads/master"...

Andreas Ericsson· Sep 24, 2008, 18:56 UTC · re: Alex Riesen · lore

Alex Riesen wrote:

Show 11 quoted lines

> 2008/9/23 rae l <crquan@gmail.com>:
>> To Git developers:
>>  I found that different git subcommand have inconsitent processing
>> about ambiguous refname,
>>
>> git show will take "master" tag first,
>> while git tag -v will take "master" branch first,
>>
>> So what's your suggestion to fix this? Just simple remove ambiguous refnames?
> 
> You can use "refs/tags/master" and "refs/heads/master"...

Apart from that..

"git tag -v" taking a branch *at all* is not something we want to happen, as it's supposed to verify the pgp signature of a signed tag. Are you absolutely 100% certain that "git tag -v" tries to verify refs/heads/master as a tag object?

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231