# Re: [TopGit RFC PATCH] tg mail: new command for mailing patches 5 messages from 2008-09-19 to 2008-09-19. Participants: Bert Wesarg, Kirill Smelkov. Thread: https://gitlist.dev/t/15588 ## Kirill Smelkov, 2008-09-19 09:08 Subject: [TopGit RFC PATCH] tg mail: new command for mailing patches Message-ID: <1221815301-25090-1-git-send-email-kirr@landau.phys.spbu.ru> URL: https://gitlist.dev/e/1221815301-25090-1-git-send-email-kirr%40landau.phys.spbu.ru ``` Petr, since you've asked for help on this, here you are: $ tg mail [NAME] a simple script to send one patch over email. All it does is - call `tg patch` for actual patch preparation - extract email addresses from whom and where to send a mail - boils down to `git send-email` It is self-hosted -- this mail was send by me with $ tg mail t/tg-mail P.S. I'm not a bash guy, please do not beat me too much... Signed-off-by: Kirill Smelkov --- .gitignore | 2 ++ README | 18 ++++++++++++++++++ tg-mail.sh | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 73 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index aa39db4..df4a662 100644 --- a/.gitignore +++ b/.gitignore @@ -5,6 +5,8 @@ tg-delete tg-delete.txt tg-info tg-info.txt +tg-mail +tg-mail.txt tg-patch tg-patch.txt tg-summary diff --git a/README b/README index b99b036..1a001a6 100644 --- a/README +++ b/README @@ -272,6 +272,24 @@ tg patch TODO: tg patch -i to base at index instead of branch, -w for working tree +tg mail +~~~~~~~ + Send a patch from the current or specified topic branch as + email. + + Takes the patch given on the command line and emails it out. + Destination addresses such as To, Cc and Bcc are taken from the + patch header. + + Since it actually boils down to `git send-email` please refer to + it's documentation for details on how to setup email for git. + + + TODO: tg mail patchfile to mail an already exported patch + TODO: mailing patch series + TODO: specifying additional options and addresses on command + line + tg remote ~~~~~~~~~ Register given remote as TopGit-controlled. This will create diff --git a/tg-mail.sh b/tg-mail.sh new file mode 100644 index 0000000..f3abd2c --- /dev/null +++ b/tg-mail.sh @@ -0,0 +1,53 @@ +#!/bin/sh +# TopGit - A different patch queue manager +# GPLv2 + +name= + + +## Parse options + +while [ -n "$1" ]; do + arg="$1"; shift + case "$arg" in + -*) + echo "Usage: tg [...] mail [NAME]" >&2 + exit 1;; + *) + [ -z "$name" ] || die "name already specified ($name)" + name="$arg";; + esac +done + +# TODO refactor me into something common? +[ -n "$name" ] || name="$(git symbolic-ref HEAD | sed 's#^refs/heads/##')" +base_rev="$(git rev-parse --short --verify "refs/top-bases/$name" 2>/dev/null)" || + die "not a TopGit-controlled branch" + + +patchfile="$(mktemp -t tg-mail.XXXXXX)" + +$tg patch $name >"$patchfile" + +hlines=$(grep -n -m 1 '^---' "$patchfile" | sed 's/:---//') +header=$(head -$(($hlines - 1)) "$patchfile") + + + +from="$(echo "$header" | grep '^From:' | sed 's/From:\s*//')" +to="$(echo "$header" | grep '^To:' | sed 's/To:\s*//')" + + +# XXX I can't get quoting right without arrays +[ -n "$from" ] && from=(--from "$from") +[ -n "$to" ] && to=(--to "$to") # FIXME there could be multimple To + +people=() +[ -n "$from" ] && people=("${people[@]}" "${from[@]}") +[ -n "$to" ] && people=("${people[@]}" "${to[@]}") + + +# NOTE git-send-email handles cc itself +git send-email "${people[@]}" "$patchfile" + +rm "$patchfile" -- tg: (6b5d0b8..) t/tg-mail (depends on: kirr) ``` ## Bert Wesarg, 2008-09-19 09:52 Subject: Re: [TopGit RFC PATCH] tg mail: new command for mailing patches Message-ID: <36ca99e90809190252q45f01eb2xd02b62b88f0cf3a9@mail.gmail.com> URL: https://gitlist.dev/e/36ca99e90809190252q45f01eb2xd02b62b88f0cf3a9%40mail.gmail.com In-Reply-To: <1221815301-25090-1-git-send-email-kirr@landau.phys.spbu.ru> ``` On Fri, Sep 19, 2008 at 11:08, Kirill Smelkov wrote: > Petr, since you've asked for help on this, here you are: > > $ tg mail [NAME] > > a simple script to send one patch over email. > > > All it does is > > - call `tg patch` for actual patch preparation > - extract email addresses from whom and where to send a mail That shouldn't be needed. git send-email parses Cc: headers and the To: comes from 'git config topgit.to', so you can re-use this. Bert ``` ## Kirill Smelkov, 2008-09-19 10:04 Subject: Re: [TopGit RFC PATCH] tg mail: new command for mailing patches Message-ID: <20080919100441.GF4423@roro3> URL: https://gitlist.dev/e/20080919100441.GF4423%40roro3 In-Reply-To: <36ca99e90809190252q45f01eb2xd02b62b88f0cf3a9@mail.gmail.com> ``` On Fri, Sep 19, 2008 at 11:52:03AM +0200, Bert Wesarg wrote: > On Fri, Sep 19, 2008 at 11:08, Kirill Smelkov wrote: > > Petr, since you've asked for help on this, here you are: > > > > $ tg mail [NAME] > > > > a simple script to send one patch over email. > > > > > > All it does is > > > > - call `tg patch` for actual patch preparation > > - extract email addresses from whom and where to send a mail > That shouldn't be needed. git send-email parses Cc: headers and the Exactly for this reason I do not extract Cc. And git send-mail does not extract From: -- it just asks to confirm From is GIT_COMMITTER_IDENT, and there is no option to stop it doing so except providing explicit --from (maybe i'm missing something?). > To: comes from 'git config topgit.to', so you can re-use this. Yes, it comes directly to .topmsg when `tg create` is done, so I thought the main source of information is the patch itself -- users may want to edit that To: by hand or add another To: lines. and what If a patch is already exported as a file, and I want to send/resend it upstream right from that file? We may want to look for topgit.to too though. -- Всего хорошего, Кирилл. ``` ## Bert Wesarg, 2008-09-19 10:20 Subject: Re: [TopGit RFC PATCH] tg mail: new command for mailing patches Message-ID: <36ca99e90809190320l4765e50eqe38bf1d2672cfcca@mail.gmail.com> URL: https://gitlist.dev/e/36ca99e90809190320l4765e50eqe38bf1d2672cfcca%40mail.gmail.com In-Reply-To: <20080919100441.GF4423@roro3> ``` On Fri, Sep 19, 2008 at 12:04, Kirill Smelkov wrote: > On Fri, Sep 19, 2008 at 11:52:03AM +0200, Bert Wesarg wrote: >> On Fri, Sep 19, 2008 at 11:08, Kirill Smelkov wrote: >> > Petr, since you've asked for help on this, here you are: >> > >> > $ tg mail [NAME] >> > >> > a simple script to send one patch over email. >> > >> > >> > All it does is >> > >> > - call `tg patch` for actual patch preparation >> > - extract email addresses from whom and where to send a mail >> That shouldn't be needed. git send-email parses Cc: headers and the > > Exactly for this reason I do not extract Cc. And git send-mail does not > extract From: -- it just asks to confirm From is GIT_COMMITTER_IDENT, > and there is no option to stop it doing so except providing explicit > --from (maybe i'm missing something?). Ahh, my fault, I should take a break, sorry for the noise. > >> To: comes from 'git config topgit.to', so you can re-use this. > > Yes, it comes directly to .topmsg when `tg create` is done, so I thought > the main source of information is the patch itself -- users may want to > edit that To: by hand or add another To: lines. Yeah, my fault, I noticed this too, its just a template. better to extract it from the patch. > > and what If a patch is already exported as a file, and I want to > send/resend it upstream right from that file? > > We may want to look for topgit.to too though. > > -- > Всего хорошего, Кирилл. > ``` ## Kirill Smelkov, 2008-09-19 10:23 Subject: Re: [TopGit RFC PATCH] tg mail: new command for mailing patches Message-ID: <20080919102355.GG4423@roro3> URL: https://gitlist.dev/e/20080919102355.GG4423%40roro3 In-Reply-To: <36ca99e90809190320l4765e50eqe38bf1d2672cfcca@mail.gmail.com> ``` On Fri, Sep 19, 2008 at 12:20:49PM +0200, Bert Wesarg wrote: > On Fri, Sep 19, 2008 at 12:04, Kirill Smelkov wrote: > > On Fri, Sep 19, 2008 at 11:52:03AM +0200, Bert Wesarg wrote: > >> On Fri, Sep 19, 2008 at 11:08, Kirill Smelkov wrote: > >> > Petr, since you've asked for help on this, here you are: > >> > > >> > $ tg mail [NAME] > >> > > >> > a simple script to send one patch over email. > >> > > >> > > >> > All it does is > >> > > >> > - call `tg patch` for actual patch preparation > >> > - extract email addresses from whom and where to send a mail > >> That shouldn't be needed. git send-email parses Cc: headers and the > > > > Exactly for this reason I do not extract Cc. And git send-mail does not > > extract From: -- it just asks to confirm From is GIT_COMMITTER_IDENT, > > and there is no option to stop it doing so except providing explicit > > --from (maybe i'm missing something?). > Ahh, my fault, I should take a break, sorry for the noise. No problem, your "noise" is welcome :) -- Всего хорошего, Кирилл. ```