# [PATCH] sha1_file: link() returns -1 on failure, not errno 1 messages from 2008-09-18 to 2008-09-18. Participants: Thomas Rast. Thread: https://gitlist.dev/t/15581 ## Thomas Rast, 2008-09-18 22:24 Subject: [PATCH] sha1_file: link() returns -1 on failure, not errno Message-ID: <1221776686-13284-1-git-send-email-trast@student.ethz.ch> URL: https://gitlist.dev/e/1221776686-13284-1-git-send-email-trast%40student.ethz.ch ``` 5723fe7 changed the call to use link() directly instead of through a custom wrapper, but forgot that it returns 0 or -1, not 0 or errno. Signed-off-by: Thomas Rast --- sha1_file.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/sha1_file.c b/sha1_file.c index 9ee1ed1..aec81bb 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -2136,7 +2136,9 @@ static void write_sha1_file_prepare(const void *buf, unsigned long len, */ int move_temp_to_file(const char *tmpfile, const char *filename) { - int ret = link(tmpfile, filename); + int ret = 0; + if (link(tmpfile, filename)) + ret = errno; /* * Coda hack - coda doesn't like cross-directory links, -- tg: (97d7fee..) t/link-returns-minus1 (depends on: origin/master) ```