threads / discuss / 15558

Submitting patches from unsubscribed authors?

Subject: Submitting patches from unsubscribed authors?

## tl;dr

4 messages between Sep 16, 2008 and Sep 16, 2008.

replies: 3people: 2as markdown or json

Jonathan del Strother· Sep 16, 2008, 23:24 UTC · lore

Is it possible to submit a patch to the mailing list, from an author that isn't subscribed? Last time I submitted a patch I went via my throwaway email address, and so that was used as the commit author. It looks like "git am" is always going to just use the email address used to post to the mailing list as the email address, but I'm sure in the past that my patches have appeared under my real email. Was that just manual intervention by the maintainer?

Jeff King· Sep 16, 2008, 23:36 UTC · re: Jonathan del Strother · lore

Re: Submitting patches from unsubscribed authors?

On Wed, Sep 17, 2008 at 12:24:48AM +0100, Jonathan del Strother wrote:

> Is it possible to submit a patch to the mailing list, from an author
> that isn't subscribed?  Last time I submitted a patch I went via my

Yes. The list accepts mail from non-subscribers.

Show 5 quoted lines

> throwaway email address, and so that was used as the commit author.
> It looks like "git am" is always going to just use the email address
> used to post to the mailing list as the email address, but I'm sure in
> the past that my patches have appeared under my real email.  Was that
> just manual intervention by the maintainer?

Yes, it pulls it from the From: header. However, you can override that by including

  From: Your Real Name <yourrealaddress>

as the first line of the mail. git-send-email will do this for you automagically if the commit author and your email sending address are not the same.

Look at some of your previous patches to the list; they have this line.

-Peff

Jonathan del Strother· Sep 16, 2008, 23:44 UTC · re: Jeff King · lore

Re: Submitting patches from unsubscribed authors?

On Wed, Sep 17, 2008 at 12:36 AM, Jeff King <peff@peff.net> wrote:

Show 6 quoted lines

> On Wed, Sep 17, 2008 at 12:24:48AM +0100, Jonathan del Strother wrote:
>
>> Is it possible to submit a patch to the mailing list, from an author
>> that isn't subscribed?  Last time I submitted a patch I went via my
>
> Yes. The list accepts mail from non-subscribers.

Ah. I was getting mail rejected when I was trying to use my real email address, but now I look more closely, they're rejected because I was sending via a local postfix server & it didn't recognise the hostname. Doh...

Show 5 quoted lines

>> throwaway email address, and so that was used as the commit author.
>> It looks like "git am" is always going to just use the email address
>> used to post to the mailing list as the email address, but I'm sure in
>> the past that my patches have appeared under my real email.  Was that
>> just manual intervention by the maintainer?

Show 12 quoted lines

>
> Yes, it pulls it from the From: header. However, you can override that
> by including
>
>  From: Your Real Name <yourrealaddress>
>
> as the first line of the mail. git-send-email will do this for you
> automagically if the commit author and your email sending address are
> not the same.
>
> Look at some of your previous patches to the list; they have this line.
>

I assumed that I was confusing git-send-email with my multiple email addresses and that was a broken header. git-am will work fine with that second From: line being embedded in the commit message, then?

Jeff King· Sep 16, 2008, 23:48 UTC · re: Jonathan del Strother · lore

Re: Submitting patches from unsubscribed authors?

On Wed, Sep 17, 2008 at 12:44:55AM +0100, Jonathan del Strother wrote:

> I assumed that I was confusing git-send-email with my multiple email
> addresses and that was a broken header.  git-am will work fine with
> that second From: line being embedded in the commit message, then?

Yep. It's a feature. See git-am(1), section "DISCUSSION".

-Peff