# [StGit PATCH] Autosign newly created patches 4 messages from 2008-09-12 to 2008-09-15. Participants: Catalin Marinas, Karl Hasselström. Thread: https://gitlist.dev/t/15508 ## Catalin Marinas, 2008-09-12 21:55 Subject: [StGit PATCH] Autosign newly created patches Message-ID: <20080912215515.10270.32667.stgit@localhost.localdomain> URL: https://gitlist.dev/e/20080912215515.10270.32667.stgit%40localhost.localdomain ``` This patch adds the autosign configuration variable which is checked by the "new" command to automatically sign the patch message. Signed-off-by: Catalin Marinas --- BTW, what happened to the patchdescr.tmpl file? It doesn't seem to be used anymore, however one can save a template file examples/gitconfig | 3 +++ stgit/commands/new.py | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/examples/gitconfig b/examples/gitconfig index 4a36202..9efc089 100644 --- a/examples/gitconfig +++ b/examples/gitconfig @@ -14,6 +14,9 @@ # Automatically Bcc the address below #autobcc = your.name@yourcompany.com + # Automatically sign newly created patches + #autosign = Signed-off-by + # Set to 'yes' if you don't want to use the 'resolved' command. # 'refresh' will automatically mark the conflicts as resolved #autoresolved = no diff --git a/stgit/commands/new.py b/stgit/commands/new.py index eb45e1b..4a58d52 100644 --- a/stgit/commands/new.py +++ b/stgit/commands/new.py @@ -21,6 +21,7 @@ from optparse import make_option from stgit import argparse, utils from stgit.commands import common from stgit.lib import git as gitlib, transaction +from stgit.config import config help = 'create a new patch and make it the topmost one' usage = """%prog [options] [name] @@ -72,8 +73,13 @@ def func(parser, options, args): # Add Signed-off-by: or similar. if options.sign_str != None: + sign_str = options.sign_str + else: + sign_str = config.get("stgit.autosign") + + if sign_str != None: cd = cd.set_message( - utils.add_sign_line(cd.message, options.sign_str, + utils.add_sign_line(cd.message, sign_str, cd.committer.name, cd.committer.email)) if options.save_template: ``` ## Karl Hasselström, 2008-09-14 08:37 Subject: Re: [StGit PATCH] Autosign newly created patches Message-ID: <20080914083728.GB30664@diana.vm.bytemark.co.uk> URL: https://gitlist.dev/e/20080914083728.GB30664%40diana.vm.bytemark.co.uk In-Reply-To: <20080912215515.10270.32667.stgit@localhost.localdomain> ``` On 2008-09-12 22:55:56 +0100, Catalin Marinas wrote: > This patch adds the autosign configuration variable which is checked > by the "new" command to automatically sign the patch message. Sounds useful. I have a sign-off command in my .emacs, but I expect this would be useful for those who don't. > BTW, what happened to the patchdescr.tmpl file? It doesn't seem to > be used anymore, however one can save a template file I don't know. I don't use it myself, so it's perfectly possible that I've broken it without noticing, seeing as there is no test suite coverage ... -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle ``` ## Catalin Marinas, 2008-09-14 21:05 Subject: Re: [StGit PATCH] Autosign newly created patches Message-ID: URL: https://gitlist.dev/e/b0943d9e0809141405u6e309f11q80edcfd59eb942dd%40mail.gmail.com In-Reply-To: <20080914083728.GB30664@diana.vm.bytemark.co.uk> ``` 2008/9/14 Karl Hasselström : > On 2008-09-12 22:55:56 +0100, Catalin Marinas wrote: > >> This patch adds the autosign configuration variable which is checked >> by the "new" command to automatically sign the patch message. > > Sounds useful. I have a sign-off command in my .emacs, but I expect > this would be useful for those who don't. I use emacs for writing code but not that much for stgit commands (I prefer the shell). >> BTW, what happened to the patchdescr.tmpl file? It doesn't seem to >> be used anymore, however one can save a template file > > I don't know. I don't use it myself, so it's perfectly possible that > I've broken it without noticing, seeing as there is no test suite > coverage ... There isn't a test but the command description suggests that patchdesr.tmpl file will be used if present. Should we keep this feature? The only case where I was using it was for automatic signed-off-by line. -- Catalin ``` ## Karl Hasselström, 2008-09-15 07:43 Subject: Re: [StGit PATCH] Autosign newly created patches Message-ID: <20080915074315.GA14452@diana.vm.bytemark.co.uk> URL: https://gitlist.dev/e/20080915074315.GA14452%40diana.vm.bytemark.co.uk In-Reply-To: ``` On 2008-09-14 22:05:04 +0100, Catalin Marinas wrote: > There isn't a test but the command description suggests that > patchdesr.tmpl file will be used if present. > > Should we keep this feature? The only case where I was using it was > for automatic signed-off-by line. I don't really have an opinion, as I don't use it. -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle ```