On Tue, Sep 09, 2008 at 04:44:11PM +0530, dhruva wrote:
> Hello,
Hi,
Show 14 quoted lines
> I feel the configuration must be set the first time only, when you > clone using 'git-p4 clone'. Altering it in between will be very > confusing! > Ideally, the setting must be transferred when the git repo > (cloned from git-p4) is cloned using standard git. Is it something > possible (well, I am new to git and am exploring. Any extra > information would help). > > My proposal is as follows: > 1. Add an extra command line argument to 'git-p4 clone' to either > enable/disable keyword expansion > 2. Store that information under the .git folder in a file that is > copied when someone clones that repo > 3. Use the stored information in future 'git-p4 sync/rebase'
Any way to make it optional would be welcome by me.
> I agree that keyword expansion is bad but there is no alternative > when you work with a system that has keyword expansion and you > need interoperability (p4<->git)
A patch would only fail if it has a hunk containing a line with keyword expansion in it. So I for one am willing to _occasionally_ have to submit to perforce manually, for the benefits of no keyword expansion - among other things, the ability to diff between branches without the interferences is very important for me.
But that's just my 2 cents, and I'm just another git(-p4) user. If you do come up with a "formal" patch, you might want to explicitly add Simon Hausmann to the To list, for he's the git-p4 author.
Cheers.
-- Jing ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.