threads / patch / 15420

patchgitk: Fix a bug in collapsing deeply nested trees.

Subject: [PATCH (GITK FIX)] gitk: Fix a bug in collapsing deeply nested trees.

## tl;dr

One message between Sep 8, 2008 and Sep 8, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alexander Gavrilov· Sep 8, 2008, 07:28 UTC · lore
To reproduce: expand a tree like this, then collapse A:
+A
 +B
   C
   D
The result is:
-A
   C
   D

I.e. sub-nodes expanded from the last sub-node of the item being collapsed are not removed.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to gitk +1 −1
diff --git a/gitk b/gitk
index dbc6064..989a3f7 100755
--- a/gitk
+++ b/gitk
@@ -2705,7 +2705,7 @@ proc treeopendir {w dir} {
 	    $w insert e:$ix $e [highlight_tag $de]
 	}
     }
-    $w mark gravity e:$ix left
+    $w mark gravity e:$ix right
     $w conf -state disabled
     set treediropen($dir) 1
     set top [lindex [split [$w index @0,0] .] 0]
-- 
1.6.0.20.g6148bc

← back to recent threads