threads / patch / 15289

patchRemove 'add' command entries from stgit-completion.bash

Subject: [StGit PATCH] Remove 'add' command entries from stgit-completion.bash

## tl;dr

5 messages between Aug 30, 2008 and Sep 6, 2008. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

Shinya Kuribayashi· Aug 30, 2008, 19:46 UTC · lore

"stg add" was dropped several months ago.

Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
---
contrib/stgit-completion.bash |    2 --
1 files changed, 0 insertions(+), 2 deletions(-)

Show changes to contrib/stgit-completion.bash +0 −2

diff --git a/contrib/stgit-completion.bash b/contrib/stgit-completion.bash
index 1867e6b..a25a603 100644
--- a/contrib/stgit-completion.bash
+++ b/contrib/stgit-completion.bash
@@ -11,7 +11,6 @@
#         . ~/.stgit-completion.bash

_stg_commands="
-    add
    applied
    branch
    delete
@@ -264,7 +263,6 @@ _stg ()
        # working-copy commands
        diff)   _stg_patches_options $command _applied_patches "-r --range" ;;
	resolved) _complete_files $command "$(_conflicting_files)" ;;
-	add)	_complete_files $command "$(_unknown_files)" ;;
#	rm)	_complete_files $command "$(_known_files)" ;;
	# commands that usually raher accept branches
	branch) _complete_branch $command _all_branches ;;

Shinya Kuribayashi· Aug 30, 2008, 20:30 UTC · re: Shinya Kuribayashi · lore

[StGit PATCH revised] Remove add/applied/unapplied bash completion entries

These commands are not available any more.

Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
---
Shinya Kuribayashi wrote:

> "stg add" was dropped several months ago.

Hm, I should have removed applied/unapplied entries also.

thanks,

  Shinya

 contrib/stgit-completion.bash |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Show changes to contrib/stgit-completion.bash +0 −4

diff --git a/contrib/stgit-completion.bash b/contrib/stgit-completion.bash
index 1867e6b..ac868e7 100644
--- a/contrib/stgit-completion.bash
+++ b/contrib/stgit-completion.bash
@@ -11,8 +11,6 @@
 #         . ~/.stgit-completion.bash
 
 _stg_commands="
-    add
-    applied
     branch
     delete
     diff
@@ -51,7 +49,6 @@ _stg_commands="
     status
     sync
     top
-    unapplied
     uncommit
     unhide
 "
@@ -264,7 +261,6 @@ _stg ()
         # working-copy commands
         diff)   _stg_patches_options $command _applied_patches "-r --range" ;;
 	resolved) _complete_files $command "$(_conflicting_files)" ;;
-	add)	_complete_files $command "$(_unknown_files)" ;;
 #	rm)	_complete_files $command "$(_known_files)" ;;
 	# commands that usually raher accept branches
 	branch) _complete_branch $command _all_branches ;;

Shinya Kuribayashi· Sep 5, 2008, 17:16 UTC · re: Shinya Kuribayashi · lore

[StGit PATCH rev3] contrib/stgit-completion.bash: Remove add/applied/cp/rm/unapplied

These commands are no longer available.

Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
---

Shinya Kuribayashi wrote:

> > "stg add" was dropped several months ago.
> 
> Hm, I should have removed applied/unapplied entries also.

Sorry for the noise, again. I've still missed `cp' and `rm', sigh. Hope this one is finally get merged. Thanks!

  Shinya

 contrib/stgit-completion.bash |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

Show changes to contrib/stgit-completion.bash +0 −7

diff --git a/contrib/stgit-completion.bash b/contrib/stgit-completion.bash
index 1867e6b..1467c28 100644
--- a/contrib/stgit-completion.bash
+++ b/contrib/stgit-completion.bash
@@ -11,8 +11,6 @@
 #         . ~/.stgit-completion.bash
 
 _stg_commands="
-    add
-    applied
     branch
     delete
     diff
@@ -20,7 +18,6 @@ _stg_commands="
     clone
     coalesce
     commit
-    cp
     edit
     export
     files
@@ -44,14 +41,12 @@ _stg_commands="
     rename
     repair
     resolved
-    rm
     series
     show
     sink
     status
     sync
     top
-    unapplied
     uncommit
     unhide
 "
@@ -264,8 +259,6 @@ _stg ()
         # working-copy commands
         diff)   _stg_patches_options $command _applied_patches "-r --range" ;;
 	resolved) _complete_files $command "$(_conflicting_files)" ;;
-	add)	_complete_files $command "$(_unknown_files)" ;;
-#	rm)	_complete_files $command "$(_known_files)" ;;
 	# commands that usually raher accept branches
 	branch) _complete_branch $command _all_branches ;;
 	rebase) _complete_branch $command _all_branches ;;

Karl Hasselström· Sep 6, 2008, 06:18 UTC · re: Shinya Kuribayashi · lore

Re: [StGit PATCH rev3] contrib/stgit-completion.bash: Remove add/applied/cp/rm/unapplied

On 2008-09-06 02:16:22 +0900, Shinya Kuribayashi wrote:

> These commands are no longer available.

Thanks again.

> Hope this one is finally get merged. Thanks!

It will -- Catalin and I have both been busy this week, but I have some time set aside for StGit this weekend.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

Karl Hasselström· Sep 6, 2008, 14:28 UTC · re: Shinya Kuribayashi · lore

Re: [StGit PATCH rev3] contrib/stgit-completion.bash: Remove add/applied/cp/rm/unapplied

On 2008-09-06 02:16:22 +0900, Shinya Kuribayashi wrote:

> Hope this one is finally get merged.  Thanks!

I've applied your patches and pushed them out on my "safe" branch, which Catalin pulls into his "master" every now and then.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle